Conversation
seafile-dev
requested changes
Aug 3, 2026
seafile-dev
left a comment
There was a problem hiding this comment.
Verdict: Request changes
Blocking:
- The task explicitly requires @seafile/seafile-calendar 1.0.13. This PR changes neither its dependency declaration nor package-lock.json; the reviewed head still declares ^1.0.10 and resolves 1.0.10.
Suggested fix: set the dependency to the intended 1.0.13-compatible range and regenerate/commit package-lock.json before releasing this shared component.
seafile-dev
requested changes
Aug 3, 2026
seafile-dev
left a comment
There was a problem hiding this comment.
Verdict: Request changes
Blocking:
- The task requires @seafile/seafile-calendar 1.0.13, but this PR does not update its manifest or lockfile; the reviewed lockfile still resolves 1.0.10.
Suggested fix: update the declared dependency and committed lockfile to resolve 1.0.13, then verify the paired applications install it.
Warnings:
- Async user-select keyboard highlight state is retained across result replacement and its visible highlight style was removed (inline comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.