Skip to content

update ui - #459

Merged
LJHAAAAA merged 5 commits into
masterfrom
uiss
Aug 7, 2026
Merged

update ui#459
LJHAAAAA merged 5 commits into
masterfrom
uiss

Conversation

@gzcqqqqqqqq1

Copy link
Copy Markdown
Contributor

No description provided.

@seafile-dev seafile-dev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Request changes

Blocking:

  • The task explicitly requires @seafile/seafile-calendar 1.0.13. This PR changes neither its dependency declaration nor package-lock.json; the reviewed head still declares ^1.0.10 and resolves 1.0.10.
    Suggested fix: set the dependency to the intended 1.0.13-compatible range and regenerate/commit package-lock.json before releasing this shared component.

@seafile-dev seafile-dev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Request changes

Blocking:

  • The task requires @seafile/seafile-calendar 1.0.13, but this PR does not update its manifest or lockfile; the reviewed lockfile still resolves 1.0.10.
    Suggested fix: update the declared dependency and committed lockfile to resolve 1.0.13, then verify the paired applications install it.

Warnings:

  • Async user-select keyboard highlight state is retained across result replacement and its visible highlight style was removed (inline comment).

@seatable seatable deleted a comment from seafile-dev Aug 4, 2026
@seatable seatable deleted a comment from seafile-dev Aug 4, 2026
@LJHAAAAA
LJHAAAAA merged commit 4b8473d into master Aug 7, 2026
1 check passed
@LJHAAAAA
LJHAAAAA deleted the uiss branch August 7, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants