Conversation
Companion
force-pushed
the
fix/watch-absolute-input-path
branch
from
August 31, 2026 20:57
a9eb8a7 to
f70e5b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #309
Problem
Watch mode silently ignores file changes when the configured input is an absolute path inside the current working directory.
File watcher events use absolute paths, while the worker tree stores paths using the same representation as the configured input. The watcher previously made event paths relative to the current directory unconditionally, causing them to no longer match the absolute worker tree paths.
The initial build still succeeded, making the watcher appear operational despite subsequent changes being ignored.
Change
Only make watcher event paths relative when the configured input path is also relative.
The mapping remains lexical, allowing removed files to be handled without requiring them to exist. Existing symlink remapping continues to take precedence.
Testing
Added focused tests covering:
Also verified watch mode using relative and absolute inputs with automatically discovered, explicitly relative and explicitly absolute configuration paths. Changes to primary files, external dependencies and configuration files were detected in every configuration.
Verified with:
cargo test -qcargo fmt --checkcargo clippy --lib --bins --tests --all-features -- -D warningslua ./scripts/test-commands.luagit diff --check