feat(python): support array and tensor conversions for DenseVector - #97
Open
dhairyathareja1 wants to merge 2 commits into
Open
dhairyathareja1 wants to merge 2 commits into
dhairyathareja1 wants to merge 2 commits into
Conversation
peopleig
requested changes
Sep 30, 2026
peopleig
left a comment
peopleig
left a comment
Contributor
There was a problem hiding this comment.
Pretty good
Run ruff on this once though
| raise ValueError("DenseVector expects a one-dimensional vector") | ||
|
|
||
| for v in normalized_values: | ||
| if not isinstance(v, (int, float)): |
Contributor
There was a problem hiding this comment.
A list of numpy floats is not accepted.
Should change this to if not isinstance(v, (int, float, numbers.Real)), or simply if not isinstance(v, numbers.Real)
Author
There was a problem hiding this comment.
Resolved. I ran ruff and fixed all reported findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds duck typed support for NumPy arrays and PyTorch, TensorFlow, and JAX tensors in DenseVector, with reverse conversion helpers, tests, and documentation.
Tests:
python -m pytest -q(99 passed)Closes #69