Fix JSONDecodeError when JSON-LD script is HTML-entity-encoded#249
Open
gaoflow wants to merge 1 commit into
Open
Fix JSONDecodeError when JSON-LD script is HTML-entity-encoded#249gaoflow wants to merge 1 commit into
gaoflow wants to merge 1 commit into
Conversation
Some sites incorrectly HTML-encode the content of application/ld+json script tags (e.g. " instead of "), causing json.loads to raise a JSONDecodeError. Apply html.unescape() before parsing so named entities like " and &, and numeric references like &scrapinghub#34;, are decoded to their character equivalents before the JSON parser sees them. Fixes scrapinghub#208
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some websites incorrectly HTML-encode the content of
application/ld+jsonscript tags, producing sequences like"or"instead of literal". When lxml extracts the text of such a<script>element it preserves those entities as-is, sojson.loadsreceives invalid JSON and raises aJSONDecodeError.Minimal reproduction (fixes #208):
Fix
Call
html.unescape()on the extracted script text before passing it tojson.loads. This converts"→",&→&,"→", etc. Sincehtml.unescapeis a no-op on plain text that contains no entities, existing valid JSON-LD is unaffected.The change is a 2-line addition to
_extract_itemsinextruct/jsonld.py.Tests
Added
test_jsonld_with_html_entitiescovering:"for double-quotes"for double-quotes&in a string valueThis pull request was prepared with the assistance of AI, under my direction and review.