Remove the ship class limit - #7746
Merged
Goober5000 merged 1 commit intoAug 31, 2026
Merged
Conversation
Goober5000
force-pushed
the
feature/remove_ship_class_limits
branch
from
August 31, 2026 00:28
e271a4a to
e179d6d
Compare
Goober5000
marked this pull request as ready for review
August 31, 2026 00:28
wookieejedi
approved these changes
Aug 31, 2026
Goober5000
marked this pull request as draft
August 31, 2026 02:53
With every fixed-size ship-class-indexed structure now converted to dynamic containers, we can finally remove the `MAX_SHIP_CLASSES` limit! Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Goober5000
force-pushed
the
feature/remove_ship_class_limits
branch
from
August 31, 2026 03:00
e179d6d to
f353ca7
Compare
Goober5000
marked this pull request as ready for review
August 31, 2026 03:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With every fixed-size ship-class-indexed structure now converted to dynamic containers, we can finally remove the
MAX_SHIP_CLASSESlimit!This depends on PRs #7737, #7739, #7742, and #7743. It is in draft until they are merged.