Modernize barracks pilot-stats line storage - #7740
Open
Goober5000 wants to merge 1 commit into
Open
Conversation
Goober5000
added
cleanup
The pilot-stats panel built its display lines into two hand-rolled fixed-width C arrays with manual dynamic memory management. Replace all of that with a growable SCP_vector<barracks_stat_line>. Most manual management goes away; the display output is unchanged. Add a reusable SCP_string overload of font::force_fit_string() so the width-fitting pass can operate on the vector's strings directly; it forwards to the existing char* version (which only ever shortens) and resizes to the result. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Goober5000
force-pushed
the
refactor/barracks_modernization
branch
from
August 25, 2026 03:44
7cfd915 to
0fe0e98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pilot-stats panel built its display lines into two hand-rolled fixed-width C arrays with manual dynamic memory management. Replace all of that with a growable SCP_vector<barracks_stat_line>. Most manual management goes away; the display output is unchanged.
Add a reusable SCP_string overload of font::force_fit_string() so the width-fitting pass can operate on the vector's strings directly; it forwards to the existing char* version (which only ever shortens) and resizes to the result.