Fix NX class membership checks - #305
Open
CAOShurong wants to merge 1 commit into
Open
CAOShurong wants to merge 1 commit into
CAOShurong wants to merge 1 commit into
Conversation
Signed-off-by: CAOShurong <170531907+CAOShurong@users.noreply.github.com>
Member
|
Thanks! However, this will unfortunately break a number of our downstream uses, many callers rely on getting {} back:
That is, we likely need to think more how to approach this, or refactor all downstream uses first. |
Member
|
A less disruptive option from the issue would give the same user-facing fix without breaking callers: define |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeyErrorwhen an NX-class lookup has no matching direct childrenNXdata in groupis false when absent, whilegroup.get(NXdata, default)returns the defaultFixes #241.
Validation
NXdata in groupas true and returned{}from bothgroup[NXdata]andgroup.get(NXdata)python -m pytest— 337 passed, 3 skippedpython -m mypy .— passedKeyErrorkey, andMapping.getdefault behavior passedImplementation and validation were performed with OpenAI Codex assistance. I reviewed the change and take responsibility for it.