Conversation
jokasimr
changed the title
jokasimr
changed the title
github-actions
Bot
changed the title
|
|
||
|
|
||
| def test_powder_mcstas_analytical_workflow_computes_dspacing(): | ||
| def test_powder_mcstas_analytical_workflow_computes_scattering_coordinates(): |
Member
There was a problem hiding this comment.
Why was this test "replaced"?
Contributor
Author
There was a problem hiding this comment.
It's not actually replaced. It still does the same as before, but also checks that Q is present in the data. It would probably be cleaner to make a separate test 👍
|
|
||
| expected_q = 2 * np.pi / detector.coords['dspacing'] | ||
| assert sc.allclose(result.coords['Q'], expected_q) | ||
| assert sc.identical(result.drop_coords('Q'), detector) |
SimonHeybrock
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #742