Adding rubin_proc - #25
Conversation
Changed res to not include hard-coded analysis settings.
schlafly
left a comment
schlafly
left a comment
There was a problem hiding this comment.
Some minor comments in line, but this looks pretty good, thanks!
| stamp = np.clip(np.array(psf_stamp_visit), 1e-10, np.inf) | ||
| stamp = stamp / np.sum(stamp) | ||
|
|
||
| psf = psfmod.SimplePSF(stamp) | ||
| psf.fitfun = partial(psfmod.wise_psf_fit, psfstamp=stamp) |
There was a problem hiding this comment.
We'll want to avoid relying on WISE here, since that will do some weird things, like assuming that the diffraction spikes get spread out near the ecliptic poles.
We probably want to eventually just overhaul the PSF determination, but it's also worth thinking about what the right behavior is wrt negatives in the Rubin PSF; I doubt we 'really' want to clip and renormalize, but it's fine for now.
|
|
||
| print("CROWDSOURCE is done!") | ||
|
|
||
| return res, visit_image |
There was a problem hiding this comment.
Please add a CLI along the lines of what is in simple_proc, so that you can either use this from python or from the command line. That's the if name == 'main' thing at the end.
There was a problem hiding this comment.
Just out of curiosity, have you tried the CLI? It looks right to me but it would be good to try it once.
Co-authored-by: Eddie Schlafly <eschlafly@gmail.com>
Co-authored-by: Eddie Schlafly <eschlafly@gmail.com>
Co-authored-by: Eddie Schlafly <eschlafly@gmail.com>
Co-authored-by: Eddie Schlafly <eschlafly@gmail.com>
Changed so that process() only gives back res. Also added arguments for a CLI line.
Changed from functions --> more like simple_proc codes.
Now using fit_variable_moffat_psf
| psf = psfmod.SimplePSF(stamp) | ||
|
|
||
| print("Using fit_variable_moffat_psf") | ||
| psf.fitfun = psfmod.fit_variable_moffat_psf |
There was a problem hiding this comment.
You mentioned needing an update to psf.py here, but I don't see it. You'll probably need to git add that file.
2 participants
Rubin_proc, given a visitId and detector number, will in the RSP DP1 environment: