Improvement/bb 605 alert for ingestion processing - #2821
Draft
benzekrimaha wants to merge 3 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## improvement/BB-846-retry-ingestion-reader-setup #2821 +/- ##
===================================================================================
- Coverage 75.80% 75.56% -0.24%
===================================================================================
Files 200 200
Lines 13925 13925
===================================================================================
- Hits 10556 10523 -33
- Misses 3359 3392 +33
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
benzekrimaha
force-pushed
the
improvement/BB-846-retry-ingestion-reader-setup
branch
from
August 20, 2026 13:15
bd6999f to
2f9c7f5
Compare
Both rules of the source error rate pair were named IngestionProducerSourceErrorRate3Percent, so the critical one could not be told apart from the warning one. Name it after the threshold it uses, as the zookeeper and publish error rate pairs already do. Issue: BB-605
A source whose setup fails is now retried on every cron tick, so it reports a getRaftId error roughly every five seconds for as long as it cannot be resolved, while its location ingests nothing. Nothing reports it today: the journal size and read offset gauges of that source are never published, so the lag and NoMessagesQueued alerts stay blind, and the error ratio alerts drown the failures in the reads of every healthy source, which are orders of magnitude more frequent. Alert on the absolute rate of getRaftId errors instead, which is only called to set a reader up. Ten minutes of sustained failures are needed to fire, so a source that recovers on its own, typically while its location restarts, does not alert. Issue: BB-605
The ingestion alerts were the only ones shipped without a rendering and unit test step, so a rule could be published broken or silent. Cover the new setup failure alert: it fires on a source that keeps failing, stays silent on one that recovers, and the ratio alerts are asserted silent on the same series to pin down why it is needed. Issue: BB-605
benzekrimaha
force-pushed
the
improvement/BB-605-alert-for-ingestion-processing
branch
from
August 20, 2026 13:16
0e20eb4 to
a682dd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: BB-605