Upgrade node-rdkafka to 3.6.1 - #2817
Conversation
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## development/9.5 #2817 +/- ##
===================================================
- Coverage 75.77% 75.75% -0.03%
===================================================
Files 200 200
Lines 13922 13922
===================================================
- Hits 10549 10546 -3
- Misses 3363 3366 +3
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
c.f. slack discussion, we should actually be able to do this in 9.5 branch, and so we would not need to merge #2816 |
3f74ba0 to
5d19449
Compare
Pin exactly 3.6.1 (librdkafka 2.12.0), replacing the 3.0.1 / librdkafka 2.3.0 pinned by BB-806. The constraint that forced that downgrade -- S3C brokers storing legacy v0/v1 MessageSets, which librdkafka >= 2.5 reads as NULL key and value -- is removed by S3C-11389 raising Federation's message-format pin. Measured on CI over 25 runs per arm of the full lib suite: the tree fails 20/25 jobs on librdkafka 2.3.0 and 0/25 on 2.12.0. The pin stays exact rather than a caret: ^2.12.0 previously resolved forward from node-rdkafka 2.12.0 to 2.18.0, changing the bundled librdkafka from 1.7.0 to 2.3.0 without review. Issue: BB-852
5d19449 to
c93ef79
Compare
|
Dropping the |
|
/reset |
Reset completeI have successfully deleted this pull request's integration branches. The following options are set: wait |
|
/approve |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option The following options are set: approve |
|
!done 6h |
|
!release |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
This pull request did not target the following hotfix branch(es) so they
Please check the status of the associated issue BB-852. Goodbye delthas. The following options are set: approve |
|
Release summary:
|
|
|
Pin node-rdkafka to 3.6.1 exactly (librdkafka 2.12.0), replacing the 3.0.1 / librdkafka 2.3.0 from BB-806. S3C-11389 raises Federation's message-format pin, which removes the legacy v0/v1 MessageSet constraint that forced that downgrade.
Measured on CI over 25 runs per arm of the full
libsuite: 20/25 jobs fail on librdkafka 2.3.0, and 0/25 on 2.12.0.The pin stays exact rather than a caret —
^2.12.0previously resolved forward from node-rdkafka 2.12.0 to 2.18.0, which changed the bundled librdkafka from 1.7.0 to 2.3.0 with no review.Issue: BB-852