Skip to content

Upgrade node-rdkafka to 3.6.1 - #2817

Merged
bert-e merged 2 commits into
development/9.5from
improvement/BB-852/upgrade-node-rdkafka
Aug 27, 2026
Merged

Upgrade node-rdkafka to 3.6.1#2817
bert-e merged 2 commits into
development/9.5from
improvement/BB-852/upgrade-node-rdkafka

Conversation

@delthas

@delthas delthas commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Pin node-rdkafka to 3.6.1 exactly (librdkafka 2.12.0), replacing the 3.0.1 / librdkafka 2.3.0 from BB-806. S3C-11389 raises Federation's message-format pin, which removes the legacy v0/v1 MessageSet constraint that forced that downgrade.

Measured on CI over 25 runs per arm of the full lib suite: 20/25 jobs fail on librdkafka 2.3.0, and 0/25 on 2.12.0.

The pin stays exact rather than a caret — ^2.12.0 previously resolved forward from node-rdkafka 2.12.0 to 2.18.0, which changed the bundled librdkafka from 1.7.0 to 2.3.0 with no review.

Issue: BB-852

@bert-e

bert-e commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Hello delthas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.75%. Comparing base (929145d) to head (c93ef79).
⚠️ Report is 3 commits behind head on development/9.5.

Additional details and impacted files

Impacted file tree graph
see 2 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 80.27% <ø> (ø)
Core Library 81.89% <ø> (-0.08%) ⬇️
Ingestion 70.09% <ø> (ø)
Lifecycle 80.46% <ø> (ø)
Oplog Populator 85.83% <ø> (ø)
Replication 62.04% <ø> (+0.03%) ⬆️
Bucket Scanner 85.76% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/9.5    #2817      +/-   ##
===================================================
- Coverage            75.77%   75.75%   -0.03%     
===================================================
  Files                  200      200              
  Lines                13922    13922              
===================================================
- Hits                 10549    10546       -3     
- Misses                3363     3366       +3     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.10% <ø> (ø)
api:routes 8.87% <ø> (ø)
bucket-scanner 85.76% <ø> (ø)
ft_test:queuepopulator 11.04% <ø> (+<0.01%) ⬆️
ingestion 12.26% <ø> (ø)
lib 8.80% <ø> (-0.03%) ⬇️
lifecycle 19.28% <ø> (-0.04%) ⬇️
notification 1.02% <ø> (ø)
oplogPopulator 0.13% <ø> (ø)
replication 18.82% <ø> (-0.03%) ⬇️
unit 54.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@scality scality deleted a comment from bert-e Aug 19, 2026
@bert-e

bert-e commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@delthas
delthas changed the base branch from development/9.5 to development/9.6 August 20, 2026 08:43
@delthas
delthas marked this pull request as ready for review August 20, 2026 08:43
@bert-e

bert-e commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@scality scality deleted a comment from bert-e Aug 20, 2026
@francoisferrand

francoisferrand commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

c.f. slack discussion, we should actually be able to do this in 9.5 branch, and so we would not need to merge #2816

@delthas
delthas force-pushed the improvement/BB-852/upgrade-node-rdkafka branch from 3f74ba0 to 5d19449 Compare August 26, 2026 18:00
Pin exactly 3.6.1 (librdkafka 2.12.0), replacing the 3.0.1 / librdkafka
2.3.0 pinned by BB-806. The constraint that forced that downgrade -- S3C
brokers storing legacy v0/v1 MessageSets, which librdkafka >= 2.5 reads
as NULL key and value -- is removed by S3C-11389 raising Federation's
message-format pin.

Measured on CI over 25 runs per arm of the full lib suite: the tree fails
20/25 jobs on librdkafka 2.3.0 and 0/25 on 2.12.0.

The pin stays exact rather than a caret: ^2.12.0 previously resolved
forward from node-rdkafka 2.12.0 to 2.18.0, changing the bundled
librdkafka from 1.7.0 to 2.3.0 without review.

Issue: BB-852
@delthas
delthas changed the base branch from development/9.6 to development/9.5 August 27, 2026 09:06
@delthas
delthas force-pushed the improvement/BB-852/upgrade-node-rdkafka branch from 5d19449 to c93ef79 Compare August 27, 2026 09:06
@delthas

delthas commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Dropping the /wait.

@delthas

delthas commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

/reset

@scality scality deleted a comment from francoisferrand Aug 27, 2026
@bert-e

bert-e commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: wait

@delthas

delthas commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

/approve

@scality scality deleted a comment from bert-e Aug 27, 2026
@scality scality deleted a comment from bert-e Aug 27, 2026
@bert-e

bert-e commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.6
  • development/9.0
  • development/9.1
  • development/9.2
  • development/9.3
  • development/9.4

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@delthas

delthas commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

!done 6h

@delthas

delthas commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

!release

@bert-e

bert-e commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.5

  • ✔️ development/9.6

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.6
  • development/9.0
  • development/9.1
  • development/9.2
  • development/9.3
  • development/9.4

This pull request did not target the following hotfix branch(es) so they
were left untouched:

  • hotfix/7.70.1
  • hotfix/7.4.10
  • hotfix/7.10.12
  • hotfix/7.70.15
  • hotfix/9.0.7
  • hotfix/7.4.5
  • hotfix/7.8.0
  • hotfix/9.0.4
  • hotfix/7.4.6
  • hotfix/7.4.7
  • hotfix/8.2.12
  • hotfix/7.6.0
  • hotfix/7.10.17
  • hotfix/7.70.12
  • hotfix/7.4.0
  • hotfix/7.10.3
  • hotfix/7.7.0
  • hotfix/7.10.1
  • hotfix/7.4.9
  • hotfix/7.10.0
  • hotfix/7.2.0
  • hotfix/7.4.3
  • hotfix/7.4.8
  • hotfix/7.10.4
  • hotfix/7.10.2
  • hotfix/7.4.1
  • hotfix/7.4.2
  • hotfix/7.9.0
  • hotfix/7.4.4
  • hotfix/7.10.8

Please check the status of the associated issue BB-852.

Goodbye delthas.

The following options are set: approve

@bert-e
bert-e merged commit c93ef79 into development/9.5 Aug 27, 2026
24 checks passed
@bert-e
bert-e deleted the improvement/BB-852/upgrade-node-rdkafka branch August 27, 2026 09:55
@delthas

delthas commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Release summary:

  • development/9.5: releasing 9.5.2
  • development/9.6: skipped — same tag as development/9.5

@delthas

delthas commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

BB-852: logged 6h; transitioned to Done (Fixed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants