Repository navigation
perf(task): reuse keys during journal union - #80
Merged
Merged
Conversation
morluto
marked this pull request as ready for review
October 6, 2026 19:54
Collaborator
|
Taking a look |
earakely-scale
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #77.
Compute journal union keys once per incoming/existing item, removing repeated prefix slices and key projections. Keep equality-based membership so unhashable values, deployed-environment identity and replay ordering remain supported.
For 1,000 items merged into an empty list, key projections drop from 501,500 to 1,000. Membership comparisons remain quadratic. Timings are local union microbenchmarks, not complete task runs: macOS arm64, Python 3.12.13, baseline
602d730, median of five samples.Reproduce:
Validation:
This PR is independent of the task-graph, Explorer and existing context-diff PRs.
The PR appears safe to merge; the benchmark should also measure re-recording to show the cost of the changed move branch.
Fix with agent prompt
Summary
The task journal now computes union keys once per incoming and existing item, reducing repeated work while keeping equality matching and replay order. A benchmark and regression test cover the change.
Reviews (1) · Last reviewed commit: "perf(task): reuse journal union keys"