Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
# CODEOWNERS — every PR requires review from a code owner.
# CODEOWNERS: GitHub requests a review from these owners on every pull request.
#
# The catch-all pattern below applies to all files in the repo. When paired
# with branch protection's "Require review from Code Owners", at least one of
# the listed owners must approve each PR. Multiple owners on one line are OR:
# an approval from ANY one of them (a frontier-data member, a chat-task-eng
# member, or polakamtejas) satisfies the requirement.
# Code-owner approval is not a merge requirement: the ruleset on main requires one
# approving review from anyone with write access. Multiple owners on one line are OR.
Comment on lines +3 to +4

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Review instructions disagree

The new CODEOWNERS comment says a code-owner approval is not needed, but CONTRIBUTING.md and README.md still say every pull request needs one. Update those guides alongside this comment so contributors know whose approval they need.

Prompt To Fix With AI
This is a comment left during a code review.
Path: CODEOWNERS
Line: 3-4

Comment:
**Review instructions disagree**

The new `CODEOWNERS` comment says a code-owner approval is not needed, but `CONTRIBUTING.md` and `README.md` still say every pull request needs one. Update those guides alongside this comment so contributors know whose approval they need.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Cursor Fix in Claude Code Fix in Codex

#
# Note: a team is only a valid owner if it has access to this repo.
* @scaleapi/frontier-data @scaleapi/chat-task-eng @polakamtejas
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ You need Python 3.11 or newer, [uv](https://docs.astral.sh/uv/) and, for the int
Docker.

```bash
git clone https://github.com/scaleapi/agent-env.git
cd agent-env
git clone https://github.com/scaleapi/agentenv-framework.git
cd agentenv-framework
uv venv .venv
uv pip install --python .venv/bin/python -e ./packages/agentenv-protocol -e '.[dev]'

Expand Down
6 changes: 3 additions & 3 deletions packages/agentenv-protocol/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ dev = [
"mcp>=1.25,<2",
]
[project.urls]
Homepage = "https://github.com/scaleapi/agent-env"
Repository = "https://github.com/scaleapi/agent-env/tree/main/packages/agentenv-protocol"
Issues = "https://github.com/scaleapi/agent-env/issues"
Homepage = "https://github.com/scaleapi/agentenv-framework"
Repository = "https://github.com/scaleapi/agentenv-framework/tree/main/packages/agentenv-protocol"
Issues = "https://github.com/scaleapi/agentenv-framework/issues"

[build-system]
requires = ["hatchling"]
Expand Down
6 changes: 3 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ agent-env = "agent_env.cli:cli"
hello = "agent_env.examples"

[project.urls]
Homepage = "https://github.com/scaleapi/agent-env"
Repository = "https://github.com/scaleapi/agent-env"
Issues = "https://github.com/scaleapi/agent-env/issues"
Homepage = "https://github.com/scaleapi/agentenv-framework"
Repository = "https://github.com/scaleapi/agentenv-framework"
Issues = "https://github.com/scaleapi/agentenv-framework/issues"

[tool.hatch.build.targets.wheel]
packages = ["src/agent_env"]
Expand Down
Loading