Repository navigation
refactor(config): drop the raise-only s3/ecr/aws store aliases; neutral store wording - #106
Merged
Merged
Conversation
…al store wording
The s3, ecr and aws values for AGENT_ENV_{OBJECT,IMAGE,SECRET}_STORE only raised a ConfigError
saying the backend has no built-in coordinates. The generic unknown-store error now carries the
same advice (configure the [stores.<kind>] table, unset the env var that overrides it), so the
three aliases and their constants go, and the tests that pinned them use an unknown name.
Docs, comments and messages that assumed S3, ECR or AWS Secrets Manager now say object store,
hosted backend or hosted registry, naming S3 and Cloud Storage together where an example helps.
The protocol's stalled-upload check reads its body markers from a table (S3's RequestTimeout is
the one entry); behaviour is unchanged. Stale integration-test docstrings that required AWS or
Atlas now say they run against the configured stores.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…s tools Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
| else status=$$?; echo "kept $$work to inspect"; exit $$status; fi | ||
|
|
||
| test: ## Run the full test suite (includes integration; requires Docker/Mongo/AWS) | ||
| test: ## Run every tier: unit, integration and installer (needs Docker and a local OCI registry; tests needing uv, pipx, a model endpoint or a remote sandbox skip without them) |
There was a problem hiding this comment.
The make test help says tests needing uv skip when it is missing. But the container-journey tests only check for Docker, then call uv through their fixtures. If Docker is available but uv is missing, make test fails instead of skipping those tests. Say that the container journey needs uv, or add a skip check.
Prompt To Fix With AI
This is a comment left during a code review.
Path: Makefile
Line: 68
Comment:
**Tests do not skip without uv**
The `make test` help says tests needing `uv` skip when it is missing. But the container-journey tests only check for Docker, then call `uv` through their fixtures. If Docker is available but `uv` is missing, `make test` fails instead of skipping those tests. Say that the container journey needs `uv`, or add a skip check.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Store configuration, docs and comments stop assuming S3, ECR or AWS Secrets Manager.
AGENT_ENV_OBJECT_STORE=s3,AGENT_ENV_IMAGE_STORE=ecrandAGENT_ENV_SECRET_STORE=awseach had a branch that only raised "has no built-in coordinates". Those three branches and their constants go. The generic unknown-store error now gives the same advice: configure the[stores.<kind>]table, and unset the env var, which overrides it. Those values still raiseConfigError; only the wording changes. The four tests that pinned the old wording now use an unknown name and still check that the message names both the table and the env var..env.example: "a hosted backend (S3, Cloud Storage)", "a hosted registry (ECR)", "a hosted secret manager (AWS Secrets Manager, Google Cloud Secret Manager)"._get_secret's error says what a bundle-backed store is instead of naming backends.tar_gz_object_url), the file-artifact upload, the artifact store, deploy-time signing, the universe bulk-download CLI and the env-state CLI say object store or hosted store.preflightsays "no store access"._is_s3_request_timeoutbecomes_is_store_request_timeout, reading its body markers from a table. S3'sRequestTimeoutis the only entry; Cloud Storage answers a stall with a 408, which the status check already retries. Behaviour is unchanged.make test's help says Docker and a local OCI registry.Left alone on purpose:
VMImageArtifact, whose shape is still being decided.No release needed: nothing changes behaviour, so this ships with the next one.
Testing
test_optional_extras_stay_optional[sail]and its sibling fail the same way onmain. They read the installed distribution's metadata, and my venv's installed copy predates thesailextra.🤖 Generated with Claude Code
The PR appears safe to merge, though the
make testhelp should be corrected.Fix with agent prompt
Summary
Store configuration errors and project wording no longer treat S3, ECR, or AWS as the only hosted options. The PR also makes stalled-upload retry matching store-neutral while keeping its current behavior.
Reviews (2) · Last reviewed commit: "chore(make): say which tiers make test r..." · Reviewed by Greptile