Potential fix for code scanning alert no. 5: Clear-text logging of sensitive information#38
Open
rajivmucheli wants to merge 1 commit into
Open
Potential fix for code scanning alert no. 5: Clear-text logging of sensitive information#38rajivmucheli wants to merge 1 commit into
rajivmucheli wants to merge 1 commit into
Conversation
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
dorneanu
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/sapcc/PyKMIP/security/code-scanning/5
To fix the problem, we should avoid logging the secret ID in clear text. Instead, we can log a generic success message, similar to how other secret derivation operations are handled in this file (see lines 126 and 175). Specifically, in kmip/demos/pie/derive_key.py, replace the line that logs
"Secret ID: {0}".format(secret_id)with a message indicating that a new secret has been derived, but its ID will not be logged for security reasons. No new imports or methods are required; just update the log statement.Suggested fixes powered by Copilot Autofix. Review carefully before merging.