test: fix stale lockstep counts for #2184 semaphore sync (flag + job) - #2202
Merged
Conversation
PR #2197 (#2184 Semaphore taxonomy auto-sync) added the SEMAPHORE_SYNC_ENABLED managed DB flag and the semaphore-tag-sync scheduled job but did not update the two lockstep-counter assertions, breaking unit tests on DEV. - db-flags.test.js: managed flag count 14 -> 15 (3 assertions) - scheduler-registry.test.js: job count 49 -> 50 + assert the new semaphore-tag-sync job name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Unit tests failing on DEV (
unit testsworkflow, 4 failures):test/unit/db-flags.test.js— expected 14 managed flags, got 15test/unit/srv/scheduler-registry.test.js— expected 49 jobs, got 50Root cause
PR #2197 (#2184 Semaphore taxonomy auto-sync) legitimately added:
SEMAPHORE_SYNC_ENABLEDmanaged DB feature flag (srv/lib/feature-flags/registry.js)semaphore-tag-syncscheduled job (srv/jobs/scheduler.js)…but did not bump the two lockstep-counter assertions that guard those registries. Feature ships dark (default OFF), so only the test counters are stale — no product bug.
Fix
semaphore-tag-syncjob name.Both files green locally (17/17).