fix(ci): allowlist GET /content/channel-detail/:slug (route-drift guard) - #2170
Merged
Merged
Conversation
#2169 added the channel-detail serve route to srv/server.js but not srv-qa/server.js, tripping check-srv-qa-route-drift. The channel-detail page is a public prod content surface (like /content/topics/:slug), not tutorial-draft author preview, and its publish sibling POST /content/publish/render-channels is already allowlisted. Add the serve counterpart to ALLOWLIST_ONLY_ON_SRV.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Unit-tests CI is red on DEV (and on the merged #2169 branch). The failing step is the
check-srv-qa-route-driftstatic build guard, not a test assertion:Cause
#2169 (Channel Atlas / channels-hub Phase 2–3) added the
GET /content/channel-detail/:slugserve route tosrv/server.jsbut not tosrv-qa/server.js. The guard enforces/content/*route parity between the two channels unless a route is allowlisted.Fix
channel-detail is a public prod content surface (channel-prefixed BLOBs, lowercase-canonicalize + 301), analogous to
GET /content/topics/:slug— not a tutorial-draft author-preview endpoint. Its publish siblingPOST /content/publish/render-channelsis already inALLOWLIST_ONLY_ON_SRV; #2169 simply missed the serve counterpart. This adds it with the matching justification.Verification