Skip to content

fix(ci): allowlist GET /content/channel-detail/:slug (route-drift guard) - #2170

Merged
jung-thomas merged 1 commit into
DEVfrom
worktree-fix-channel-detail-route-drift
Sep 6, 2026
Merged

fix(ci): allowlist GET /content/channel-detail/:slug (route-drift guard)#2170
jung-thomas merged 1 commit into
DEVfrom
worktree-fix-channel-detail-route-drift

Conversation

@jung-thomas

Copy link
Copy Markdown
Contributor

Problem

Unit-tests CI is red on DEV (and on the merged #2169 branch). The failing step is the check-srv-qa-route-drift static build guard, not a test assertion:

[check-srv-qa-route-drift] FAILED — /content/* route drift detected:
  Routes on srv but MISSING from srv-qa/server.js:
    GET /content/channel-detail/:slug    (srv/server.js:829)

Cause

#2169 (Channel Atlas / channels-hub Phase 2–3) added the GET /content/channel-detail/:slug serve route to srv/server.js but not to srv-qa/server.js. The guard enforces /content/* route parity between the two channels unless a route is allowlisted.

Fix

channel-detail is a public prod content surface (channel-prefixed BLOBs, lowercase-canonicalize + 301), analogous to GET /content/topics/:slugnot a tutorial-draft author-preview endpoint. Its publish sibling POST /content/publish/render-channels is already in ALLOWLIST_ONLY_ON_SRV; #2169 simply missed the serve counterpart. This adds it with the matching justification.

Verification

npx tsx scripts/check-srv-qa-route-drift.ts
[check-srv-qa-route-drift] OK — 35 /content/* route(s) on srv, 13 on srv-qa (22 srv-only + 0 srv-qa-only allowlisted).

#2169 added the channel-detail serve route to srv/server.js but not
srv-qa/server.js, tripping check-srv-qa-route-drift. The channel-detail
page is a public prod content surface (like /content/topics/:slug), not
tutorial-draft author preview, and its publish sibling
POST /content/publish/render-channels is already allowlisted. Add the
serve counterpart to ALLOWLIST_ONLY_ON_SRV.
@jung-thomas
jung-thomas merged commit a7ebcf6 into DEV Sep 6, 2026
2 of 3 checks passed
@jung-thomas
jung-thomas deleted the worktree-fix-channel-detail-route-drift branch September 6, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant