polish(channels): tighten P4 submit-service contract (405 READ + EDIT/REMOVE target guard) - #2158
Merged
Conversation
…/REMOVE target guard)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P4 follow-up — tighten submit-service contract
Optional polish parked from the P4 (#2157) whole-branch final review. Two precision improvements on the
ChannelSubmissionServiceinsert-only submit path; no model change, no migration.Changes
test/channel-submission-service.test.jspreviously acceptedexpect.any(Number)for the READ-blocked case (would silently pass a500). Now asserts the exact CAP-10 contract:405Method Not Allowed. Confirmed empirically, not assumed.before('CREATE')now rejects anEDIT/REMOVEsubmission with notargetChannel_IDwith400and targettargetChannel_ID, instead of accepting a junkPENDINGrow that only fails later at approve. Defense-in-depth behind the island's client-siderequiredfield;ADD(no target) is unaffected.Verification
channel-submission-service.test.js: 5 passed (405 READ + two new 400 guard tests + existing anon-401/stamp tests).admin-channel-submissions,channel-submissions-model,admin-channel-submissions-app— 16 passed..cdsuntouched → no.hdbmigrationtable/csn regen.