Add APT multiarch preflight regression test - #70212
Conversation
Signed-off-by: TobiPeterG <github.threefold020@passmail.net>
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here's some information that may help as you continue your Salt journey. There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
Weird, not my first contribution |
What does this PR do?
Adds regression coverage for
pkg.installedhandling of an alreadyinstalled native-architecture APT package whose explicit package name
contains an architecture suffix.
The test reproduces the NVIDIA container package scenario with:
libnvidia-container-toolslibnvidia-container1:amd64APT reports the latter from
pkg.list_pkgs()as the normalizedlibnvidia-container1name. The test verifies thatpkg.installedrecognizes both packages as already installed and does not call
pkg.install.The test passes on the current
3006.xbranch and fails on v3006.26,where
libnvidia-container1:amd64is incorrectly passed topkg.installas an installation target.What issues does this PR fix or reference?
References #68932 and #69604.
Closes #70209
Previous Behavior
The v3006.26 preflight incorrectly considered an installed native
multiarch package missing when the desired name contained
:amd64butpkg.list_pkgs()returned its normalized name.New Behavior
The existing normalized-name fallback is covered by a regression test
using the original two-package reproduction.
Merge requirements satisfied?
Commits signed with GPG?
No