Skip to content

Add get_*cal_frac functions. For z-vertex relative jet task, add has_… - #4358

Draft
Hanpu-Jiang wants to merge 1 commit into
sPHENIX-Collaboration:masterfrom
Hanpu-Jiang:new_functions
Draft

Add get_*cal_frac functions. For z-vertex relative jet task, add has_…#4358
Hanpu-Jiang wants to merge 1 commit into
sPHENIX-Collaboration:masterfrom
Hanpu-Jiang:new_functions

Conversation

@Hanpu-Jiang

Copy link
Copy Markdown
Contributor

…zvertex, get_vertex_type, get_vertex_z functions

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work for users)
  • Requiring change in macros repository (Please provide links to the macros pull request in the last section)
  • I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

…zvertex, get_vertex_type, get_vertex_z functions
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a189ce69-aa3d-4380-b4ec-22d12c8d7682

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sphenix-jenkins-ci

Copy link
Copy Markdown

Build & test report

Report for commit 940d53a18d83f14f8cafafe49d71400744899681:
Jenkins passed


Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@pinkenburg

Copy link
Copy Markdown
Contributor

Can you verify that thsi can still read old DSTs (the DST_TRUTH_JET files should do). In principal adding data members and bumping the classdef in versioned classes works fine, but we did have occasional surprises in the past

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants