Skip to content

fix(admin): report heal runtime state#4786

Merged
overtrue merged 1 commit into
mainfrom
overtrue/heal-status-disabled
Jul 13, 2026
Merged

fix(admin): report heal runtime state#4786
overtrue merged 1 commit into
mainfrom
overtrue/heal-status-disabled

Conversation

@overtrue

Copy link
Copy Markdown
Collaborator

Related Issues

N/A

Summary of Changes

Add an explicit state field to background heal status responses so disabled and uninitialized runtimes are distinguishable from an idle runtime. The state is derived from service enablement, manager/channel initialization, and current queued or active work.

Verification

  • cargo fmt --all --check
  • cargo test -p rustfs --lib admin::handlers::heal::tests::test_background_heal -- --nocapture (build was interrupted by concurrent workspace artifact cleanup; rerun in CI)
  • Added regression coverage for disabled, uninitialized, idle, and active state mapping.

Impact

Adds a backward-compatible JSON field to POST /rustfs/admin/v3/background-heal/status. Existing clients ignoring unknown fields are unaffected; the companion rustfs/cli change is in rustfs/cli#256.

Additional Notes

The explicit state prevents an uninitialized Heal channel from being reported as idle.

Copilot AI review requested due to automatic review settings July 12, 2026 23:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown
Contributor

CLA requirements are satisfied for this pull request.

@overtrue overtrue merged commit 535d672 into main Jul 13, 2026
32 of 33 checks passed
@overtrue overtrue deleted the overtrue/heal-status-disabled branch July 13, 2026 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants