Skip to content

Extend complete profile warning with a profile-switch suggestion #5000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rami3l merged 1 commit into from
Aug 11, 2026
+7 −3
Merged

Extend complete profile warning with a profile-switch suggestion #5000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/cli/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ use crate::{
utils::{self, ExitCode},
};

pub(crate) const WARN_COMPLETE_PROFILE: &str = "downloading with complete profile isn't recommended unless you are a developer of the rust language";
pub(crate) const WARN_COMPLETE_PROFILE: &str = "\
downloading with the `complete` profile is deprecated
help: consider switching to the `default` profile with `rustup set profile default`";

pub(crate) fn confirm(question: &str, default: bool, process: &Process) -> Result<bool> {
write!(process.stdout().lock(), "{question} ")?;
Expand Down
3 changes: 2 additions & 1 deletion tests/suite/cli_inst_interactive.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,8 @@ async fn test_warn_if_complete_profile_is_used() {
.await
.with_stderr(snapbox::str![[r#"
...
warn: downloading with complete profile isn't recommended unless you are a developer of the rust language
warn: downloading with the `complete` profile is deprecated
help: consider switching to the `default` profile with `rustup set profile default`
...
"#]])
.is_ok();
Expand Down
3 changes: 2 additions & 1 deletion tests/suite/cli_v2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2467,7 +2467,8 @@ async fn test_warn_if_complete_profile_is_used() {
.await
.with_stderr(snapbox::str![[r#"
...
warn: downloading with complete profile isn't recommended unless you are a developer of the rust language
warn: downloading with the `complete` profile is deprecated
help: consider switching to the `default` profile with `rustup set profile default`
...
"#]])
.is_err();
Expand Down
Loading