First steps of late-bound turbofishing (place FnDef behind a dummy binder)#158632
First steps of late-bound turbofishing (place FnDef behind a dummy binder)#158632addiesh wants to merge 2 commits into
Conversation
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
There was a problem hiding this comment.
this change has nothing to do with LLVM and as such should probably not have A-LLVM
|
this PR probably shouldn't have as many tags as it does (A-LLVM, PG-exploit-mitigations, T-clippy, WG-trait-system-refactor) |
|
@rustbot review |
|
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Requested reviewer is already assigned to this pull request. Please choose another assignee. |
This comment has been minimized.
This comment has been minimized.
aba7ff3 to
403a9d1
Compare
git is frustrating
|
Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri Some changes occurred to the CTFE machinery Some changes occurred to constck cc @fee1-dead changes to the core type system cc @lcnr Some changes occurred in compiler/rustc_sanitizers cc @rcvalle Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt
cc @rust-lang/clippy This PR changes rustc_public cc @oli-obk, @celinval, @ouz-a, @makai410
cc @bjorn3 Some changes occurred in match checking cc @Nadrieril HIR ty lowering was modified cc @fmease Some changes occurred in match lowering cc @Nadrieril |
r? oli-obk
This PR is part of #156581. This should be functionally identical to prior behavior, with the added fact that FnDef now places its arguments behind a binder.
most changes boil down to
argsfromFnDefwithargs.no_bound_vars().unwrap()Ty::new_fn_def(/* ... */, args)withTy::new_fn_def(/* ... */, ty::Binder::dummy(args))