rustdoc: show impl Trait<Box<Local>> for Foreign, etc on Local's docs by sunshowers · Pull Request #158466 · rust-lang/rust

sunshowers · 2026-06-27T05:03:52Z

This is a generalization of #92940: that PR handled cases like impl Foreign for Box<Local>, but was missing handling for a few other closely related cases.

My particular interest was with showing impl From<Box<Utf8Path>> for Box<Path> in camino's documentation. But I ended up handling a bunch of related cases along the way.

I'm new to rustdoc so please let me know if I got anything wrong :) took a bit to fully understand how this worked.

rustbot · 2026-06-27T05:03:55Z

These commits modify tests/rustdoc-json.
rustdoc-json is a public (but unstable) interface.

Please ensure that if you've changed the output:

It's intentional.
The FORMAT_VERSION in src/librustdoc-json-types is bumped if necessary.

cc @obi1kenobi

rustbot · 2026-06-27T05:03:58Z

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: rustdoc
rustdoc expanded to 8 candidates
Random selection from GuillaumeGomez, notriddle

sunshowers · 2026-06-27T05:45:24Z

Looks like network flakiness.

rustbot · 2026-06-27T10:21:20Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

This is a generalization of PR 92940: that PR handled cases like `impl Foreign for Box<Local>`, but was missing handling for a few other closely related cases. My particular interest was with showing `impl From<Box<Utf8Path>> for Box<Path>` in camino's documentation. But I ended up handling a bunch of related cases along the way. I'm new to rustdoc so please let me know if I got anything wrong :) took a bit to fully understand how this worked.

notriddle · 2026-06-27T21:05:34Z

Looking at the old bug report, I found this line, justifying what the problem was:

We definitely need to fix this, specifically, for #[fundamental] types, because that's how you wind up with impls that aren't actually documented anywhere.

These impls have the same problems.

@bors r+

rust-bors · 2026-06-27T21:05:36Z

📌 Commit c3864be has been approved by notriddle

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened.

…otriddle rustdoc: show impl Trait<Box<Local>> for Foreign, etc on Local's docs This is a generalization of rust-lang#92940: that PR handled cases like `impl Foreign for Box<Local>`, but was missing handling for a few other closely related cases. My particular interest was with showing `impl From<Box<Utf8Path>> for Box<Path>` in camino's documentation. But I ended up handling a bunch of related cases along the way. I'm new to rustdoc so please let me know if I got anything wrong :) took a bit to fully understand how this worked. <img width="1733" height="483" alt="image" src="https://github.com/user-attachments/assets/4b987c61-bdac-4de3-a491-c0577e06fa7c" />

…uwer Rollup of 10 pull requests Successful merges: - #158502 (Revert "LLVM 23: Adapt codegen test to moved assume") - #152225 (Add supertrait item shadowing for type-level path resolution) - #158194 (Adds RmetaLinkCache a per-link cache that uses path as the key of dec…) - #158466 (rustdoc: show impl Trait<Box<Local>> for Foreign, etc on Local's docs) - #158501 (miri subtree update) - #153097 (Expand `OptionFlatten`'s iterator methods) - #158163 (Fix too-short variance slice in `variances_of` cycle recovery) - #158233 (Allow the unstable attribute on foreign type) - #158470 (Upgrade `jsonsocck` and `jsondoclint` to edition 2024.) - #158488 (Upgrade `rustdoc-json-types` to 2024 edition.)

…otriddle rustdoc: show impl Trait<Box<Local>> for Foreign, etc on Local's docs This is a generalization of rust-lang#92940: that PR handled cases like `impl Foreign for Box<Local>`, but was missing handling for a few other closely related cases. My particular interest was with showing `impl From<Box<Utf8Path>> for Box<Path>` in camino's documentation. But I ended up handling a bunch of related cases along the way. I'm new to rustdoc so please let me know if I got anything wrong :) took a bit to fully understand how this worked. <img width="1733" height="483" alt="image" src="https://github.com/user-attachments/assets/4b987c61-bdac-4de3-a491-c0577e06fa7c" />

Rollup of 15 pull requests Successful merges: - #158497 (stdarch subtree update) - #152225 (Add supertrait item shadowing for type-level path resolution) - #158194 (Adds RmetaLinkCache a per-link cache that uses path as the key of dec…) - #158466 (rustdoc: show impl Trait<Box<Local>> for Foreign, etc on Local's docs) - #158501 (miri subtree update) - #153097 (Expand `OptionFlatten`'s iterator methods) - #157614 (Move tests drop) - #157996 (perf: drop the full-crate AST walk in check_unused) - #158163 (Fix too-short variance slice in `variances_of` cycle recovery) - #158233 (Allow the unstable attribute on foreign type) - #158433 (Fix inconsistent safety requirement in VecDeque::nonoverlapping_ranges) - #158464 (Reorganize `tests/ui/issues` [15/N]) - #158470 (Upgrade `jsonsocck` and `jsondoclint` to edition 2024.) - #158485 (Reorganize `tests/ui/issues` [16/N]) - #158488 (Upgrade `rustdoc-json-types` to 2024 edition.)

Rollup of 15 pull requests Successful merges: - rust-lang/rust#158497 (stdarch subtree update) - rust-lang/rust#152225 (Add supertrait item shadowing for type-level path resolution) - rust-lang/rust#158194 (Adds RmetaLinkCache a per-link cache that uses path as the key of dec…) - rust-lang/rust#158466 (rustdoc: show impl Trait<Box<Local>> for Foreign, etc on Local's docs) - rust-lang/rust#158501 (miri subtree update) - rust-lang/rust#153097 (Expand `OptionFlatten`'s iterator methods) - rust-lang/rust#157614 (Move tests drop) - rust-lang/rust#157996 (perf: drop the full-crate AST walk in check_unused) - rust-lang/rust#158163 (Fix too-short variance slice in `variances_of` cycle recovery) - rust-lang/rust#158233 (Allow the unstable attribute on foreign type) - rust-lang/rust#158433 (Fix inconsistent safety requirement in VecDeque::nonoverlapping_ranges) - rust-lang/rust#158464 (Reorganize `tests/ui/issues` [15/N]) - rust-lang/rust#158470 (Upgrade `jsonsocck` and `jsondoclint` to edition 2024.) - rust-lang/rust#158485 (Reorganize `tests/ui/issues` [16/N]) - rust-lang/rust#158488 (Upgrade `rustdoc-json-types` to 2024 edition.)

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [camino](https://redirect.github.com/camino-rs/camino) | workspace.dependencies | patch | `1.2.3` → `1.2.4` | --- ### Release Notes <details> <summary>camino-rs/camino (camino)</summary> ### [`v1.2.4`](https://redirect.github.com/camino-rs/camino/blob/HEAD/CHANGELOG.md#124---2026-06-27) [Compare Source](https://redirect.github.com/camino-rs/camino/compare/camino-1.2.3...camino-1.2.4) ##### Added Methods to convert between `Box<Utf8Path>` and `Box<Path>`: - `From<Box<Utf8Path>> for Box<Path>` (as of release, not documented due to [rust-lang/rust#158466](https://redirect.github.com/rust-lang/rust/pull/158466)). - `Utf8Path::into_std_boxed_path(self: Box<Self>)` - `Utf8Path::from_boxed_path(path: Box<Path>)` - `TryFrom<Box<Path>> for Box<Utf8Path>` Thanks [nicopap](https://redirect.github.com/nicopap) for your first contribution! </details> --- ### Configuration 📅 **Schedule**: (in timezone America/Los_Angeles) - Branch creation - "after 8pm,before 6am" - Automerge - "after 8pm,before 6am" 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://redirect.github.com/renovatebot/renovate).

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [camino](https://redirect.github.com/camino-rs/camino) | dependencies | patch | `1.2.3` → `1.2.4` | --- ### Release Notes <details> <summary>camino-rs/camino (camino)</summary> ### [`v1.2.4`](https://redirect.github.com/camino-rs/camino/blob/HEAD/CHANGELOG.md#124---2026-06-27) [Compare Source](https://redirect.github.com/camino-rs/camino/compare/camino-1.2.3...camino-1.2.4) ##### Added Methods to convert between `Box<Utf8Path>` and `Box<Path>`: - `From<Box<Utf8Path>> for Box<Path>` (as of release, not documented due to [rust-lang/rust#158466](https://redirect.github.com/rust-lang/rust/pull/158466)). - `Utf8Path::into_std_boxed_path(self: Box<Self>)` - `Utf8Path::from_boxed_path(path: Box<Path>)` - `TryFrom<Box<Path>> for Box<Utf8Path>` Thanks [nicopap](https://redirect.github.com/nicopap) for your first contribution! </details> --- ### Configuration 📅 **Schedule**: (in timezone UTC) - Branch creation - "before 5am on monday" - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://redirect.github.com/renovatebot/renovate).  Co-authored-by: djf-renovate[bot] <289662816+djf-renovate[bot]@users.noreply.github.com>

Fixed in rust-lang/rust#158466 that's now in nightly Rust. I've rebuilt the camino 1.2.4 docs and have confirmed that the impl shows up now. https://docs.rs/camino/latest/camino/struct.Utf8Path.html#impl-From%3CBox%3CUtf8Path%3E%3E-for-Box%3CPath%3E

rustbot assigned notriddle Jun 27, 2026

This comment has been minimized.

Sign in to view

sunshowers force-pushed the nested-fundamental branch from 8887488 to 2b1bb2d Compare June 27, 2026 05:05

This comment has been minimized.

Sign in to view

sunshowers force-pushed the nested-fundamental branch from 2b1bb2d to 67cb42e Compare June 27, 2026 10:21

This comment has been minimized.

Sign in to view

sunshowers force-pushed the nested-fundamental branch from 67cb42e to c3864be Compare June 27, 2026 10:27

notriddle approved these changes Jun 27, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2026

JonathanBrouwer mentioned this pull request Jun 27, 2026

Rollup of 10 pull requests #158503

Closed

sunshowers mentioned this pull request Jun 27, 2026

Add conversion from Box<Utf8Path> to Box<Path> camino-rs/camino#122

Merged

jhpratt mentioned this pull request Jun 28, 2026

Rollup of 10 pull requests #158507

Closed

jhpratt mentioned this pull request Jun 28, 2026

Rollup of 15 pull requests #158508

Merged

rust-bors Bot merged commit a1fbf7b into rust-lang:main Jun 28, 2026
13 checks passed

rustbot added this to the 1.98.0 milestone Jun 28, 2026

sunshowers deleted the nested-fundamental branch June 28, 2026 07:09

sunshowers mentioned this pull request Jun 29, 2026

add back the link for From<Box<Utf8Path>> for Box<Path> camino-rs/camino#126

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

rustdoc: show impl Trait<Box<Local>> for Foreign, etc on Local's docs#158466

rustdoc: show impl Trait<Box<Local>> for Foreign, etc on Local's docs#158466
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
sunshowers:nested-fundamental

sunshowers commented Jun 27, 2026 •

edited by rustbot

Loading

Uh oh!

rustbot commented Jun 27, 2026

Uh oh!

rustbot commented Jun 27, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

sunshowers commented Jun 27, 2026

Uh oh!

rustbot commented Jun 27, 2026

Uh oh!

This comment has been minimized.

notriddle commented Jun 27, 2026

Uh oh!

rust-bors Bot commented Jun 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

sunshowers commented Jun 27, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 27, 2026

Uh oh!

rustbot commented Jun 27, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

sunshowers commented Jun 27, 2026

Uh oh!

rustbot commented Jun 27, 2026

Uh oh!

This comment has been minimized.

notriddle commented Jun 27, 2026

Uh oh!

rust-bors Bot commented Jun 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sunshowers commented Jun 27, 2026 •

edited by rustbot

Loading