Deny todo!() in tidy#157706
Open
jdonszelmann wants to merge 11 commits into
Open
Conversation
Collaborator
|
Some changes occurred in cc @BoxyUwU Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs cc @ZuseZ4 Some changes occurred in compiler/rustc_sanitizers cc @rcvalle Some changes occurred in match checking cc @Nadrieril Some changes occurred to the CTFE machinery This PR changes rustc_public cc @oli-obk, @celinval, @ouz-a, @makai410 Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri |
rustbot
added
A-rustdoc-json
Collaborator
|
r? @Kivooeo rustbot has assigned @Kivooeo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
Kivooeo
added
S-waiting-on-MCP
Kivooeo
reviewed
Jun 20, 2026
JonathanBrouwer
removed
the
S-waiting-on-MCP
Kivooeo
added
the
S-waiting-on-author
Collaborator
|
This PR changes a file inside Some changes occurred in coverage tests. cc @Zalathar Some changes occurred in GUI tests. Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @lolbinarycat The parser was modified, potentially altering the grammar of (stable) Rust cc @fmease This PR modifies |
rustbot
added
A-CI
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
Ideally, this would be split into two different PRs:
|
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
WaffleLapkin
requested changes
Jul 6, 2026
Comment on lines
+17
to
+23
| impl<'a> Default for Directives<'a> { | ||
| fn default() -> Self { | ||
| Self { | ||
| $($name: Directive::default()),* | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This can be just #[derive(Default)]
Comment on lines
+70
to
+71
| /// For drop-bomb behavior | ||
| Checked, |
Member
There was a problem hiding this comment.
Can you expand on drop-bomb behavior here?
Comment on lines
+79
to
+82
| /// `Ignore(false)` means that an `ignore-tidy-*` directive | ||
| /// has been provided, but is unnecessary. `Ignore(true)` | ||
| /// means that it is necessary (i.e. a warning would be | ||
| /// produced if `ignore-tidy-*` was not present). |
Member
There was a problem hiding this comment.
This documentation is outdated
Comment on lines
+99
to
+103
| impl<'a> Default for Directive<'a> { | ||
| fn default() -> Self { | ||
| Self::Deny | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This can be #[derive(Default)]
Comment on lines
+85
to
+86
| /// Some higher-level rule decides whether this directive is denied or ignored. | ||
| Derived(&'a Directive<'a>), |
Member
There was a problem hiding this comment.
Q: Why is this necessary?
It looks like this is used to make the child set the used-ness in the parent... But since this is only relevant with Ignore it should just hold Rc<Cell<...>> imo.
Comment on lines
+568
to
+570
| if trimmed.contains("ignore-tidy") { | ||
| return false; | ||
| } |
Comment on lines
+625
to
+627
| let mut fake_directives = Directives::default(); | ||
| fake_directives.odd_backticks = directive; | ||
| fake_directives.check_usage(&mut check, file); |
Member
There was a problem hiding this comment.
I honestly don't get what's going on here with fake_directives or why we need to store odd_backticks in comment_block...
| use run_make_support::{rfs, rustc}; | ||
|
|
||
| // This test make sure we don't get such following error: | ||
| // ignore-tidy-linelength |
Member
There was a problem hiding this comment.
this one is useless? shouldn't tidy have caught it? 🤔
| //@ stderr-per-bitwidth | ||
| //@ ignore-endian-big | ||
| // ignore-tidy-linelength | ||
| //@ normalize-stderr: "╾─*ALLOC[0-9]+(\+[a-z0-9]+)?(<imm>)?─*╼" -> "╾ALLOC_ID$1╼" |
Member
There was a problem hiding this comment.
why did you add this? doesn't seem like it changed .stderr...
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Member
|
r? wafflelapkin |
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
Implements rust-lang/compiler-team#999
Part of #158173