Skip to content

Implement some candidates for the new solver (redux) - #107004

Merged
bors merged 7 commits into
rust-lang:masterfrom
compiler-errors:new-solver-new-candidates-2
Jan 19, 2023
Merged

Implement some candidates for the new solver (redux)#107004
bors merged 7 commits into
rust-lang:masterfrom
compiler-errors:new-solver-new-candidates-2

Conversation

@compiler-errors

Copy link
Copy Markdown
Contributor

Based on #106718, so the diff is hard to read without it. See here for an easier view until that one lands.

Of note:

  • 44af916020fb43c12070125c45b6dee4ec303bbc fixes a bug where we need to make the query response inside of a probe, or else we make no inference progress (I think)
  • 50daad5acd2f163d03e7ffab942534f09bc36e2e implements consider_assumption for traits and predicates. I'm not sure if using sup here is necessary or if eq is fine.
  • We decided that all of the instantiate_constituent_tys_for_* functions are verbose but ok, since they need to be exhaustive and the logic between each of them is not similar enough, right?

r? @lcnr

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants