fix: skip redundant_field_names lint on macro-generated code - #17526
Closed
waterWang wants to merge 3 commits into
Closed
fix: skip redundant_field_names lint on macro-generated code#17526waterWang wants to merge 3 commits into
redundant_field_names lint on macro-generated code#17526waterWang wants to merge 3 commits into
Conversation
Collaborator
|
Thanks for the pull request, and welcome! You should hear from one of our reviewers after this PR gets at least 2 reviews from the community. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Member
|
Moderation note: user was suspended due to automated contributions (cf. rust-lang/rust#160788). |
Member
|
Hello @waterWang, seems that your account is automated (probably authored by some agent). Thanks for the warning, @jieyouxu! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17525
redundant_field_nameswas firing on code generated by proc-macro derives (e.g.,thiserror::Error), where the user cannot control the generated expansion. This adds a!field.span.from_expansion()guard to skip linting any code from macro expansions, including proc-macro derive output.Changes
clippy_lints/src/redundant_field_names.rs: added&& !field.span.from_expansion()checktests/ui/redundant_field_names.rs: removedinternal!macro lint expectation (now skipped byfrom_expansion()check)tests/ui/redundant_field_names.stderr: updated expected error count from 9 to 8