Support NonZero constants in integer_const 17481 - #17519
Open
arunsingh wants to merge 1 commit into
Open
Conversation
Signed-off-by: Arun Singh <arunsingh.in@gmail.com>
Collaborator
|
Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews. In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Contributor
Author
|
@rustbot ready |
|
Sorry for the confusion. I was referring to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: Improve internal constant evaluation for standard-library NonZero values
Fixes #17481.
Extends
clippy_utils::consts::integer_constto read scalar-backed constants whose resolved type iscore::num::NonZero<T>, including aliases such asNonZeroU32. General ADT evaluation remains unchanged.Validation:
cargo test -p clippy_utils --lib integer_constcargo dev fmt --checkgit diff --checkcargo check -p clippy_utilscargo check -p clippy_lintscargo dev dogfoodcargo test