Fix WIFSTOPPED on NetBSD - #5458
Open
krobelus wants to merge 1 commit into
Open
Conversation
If we expand the definitions from https://github.com/NetBSD/src/blob/d04b0c735abc997743bb3faa74464524cbe7becd/sys/sys/wait.h#L61 we get #define WIFCONTINUED(x) (x == 0xffff) #define WIFSTOPPED(x) ((x & 0177) == 0177 && !WIFCONTINUED(x)) Our definition of WIFSTOPPED forgot the !WIFCONTINUED(x) condition. Siince the wait(3p) status for "continued" is 0xffff, this causes WIFSTOPPED to return true for continued child processes. Fix this. Originally reported at fish-shell/fish-shell#12929
Collaborator
|
Some changes occurred in a NetBSD-like module cc @semarie |
krobelus
added a commit
to fish-shell/fish-shell
that referenced
this pull request
Sep 1, 2026
Due to a NetBSD-specific bug in rust-lang/libc, WIFSTOPPED and WIFCONTINUED both return true for continued jobs. Since we check stopped first, whenever "fg" SIGCONTs a job, the "continued" waitstatus is interpreted as another stop, confusing fish. Can be removed once we have rust-lang/libc#5458 Closes #12929
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we expand the definitions from
https://github.com/NetBSD/src/blob/d04b0c735abc997743bb3faa74464524cbe7becd/sys/sys/wait.h#L61
we get
Our definition of WIFSTOPPED forgot the !WIFCONTINUED(x) condition.
Siince the wait(3p) status for "continued" is 0xffff, this causes
WIFSTOPPED to return true for continued child processes.
Fix this.
Originally reported at fish-shell/fish-shell#12929