emscripten: Add epoll support - #5427
Merged
Merged
Conversation
6 tasks
guybedford
force-pushed
the
emscripten-apis
branch
from
August 18, 2026 23:37
1d5c1a0 to
16584c2
Compare
tgross35
reviewed
Aug 19, 2026
tgross35
added
the
stable-nominated
This comment has been minimized.
This comment has been minimized.
guybedford
force-pushed
the
emscripten-apis
branch
from
August 19, 2026 16:24
16584c2 to
88bcf99
Compare
This comment has been minimized.
This comment has been minimized.
Emscripten restored the `sys/epoll.h` header in 6.0.2 and implements `epoll_create`, `epoll_create1`, `epoll_ctl`, `epoll_wait` and `epoll_pwait` in the JS filesystem as of 6.0.8. Version detection in libc-test now also tracks the tiny version component so that point releases can be distinguished, and parses the uppercase `__EMSCRIPTEN_MAJOR__` macro forms used since Emscripten 5.0.1, where the lowercase names became non-integer aliases. Link: https://github.com/emscripten-core/emscripten/blob/4483d70a78098ed5d860dff2dc21f3025b2da2ee/system/lib/libc/musl/include/sys/epoll.h#L17 Link: https://github.com/emscripten-core/emscripten/blob/4483d70a78098ed5d860dff2dc21f3025b2da2ee/system/lib/libc/musl/include/sys/epoll.h#L70-L74 Link: emscripten-core/emscripten#27206 Link: emscripten-core/emscripten#27207
guybedford
force-pushed
the
emscripten-apis
branch
from
August 19, 2026 21:32
88bcf99 to
0cf3493
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
tgross35
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the epoll APIs for the
wasm32-unknown-emscriptentarget. Emscripten restored thesys/epoll.hheader in 6.0.2 (emscripten-core/emscripten#27206) and implements the epoll functions in the JS filesystem as of the upcoming 6.0.8 (emscripten-core/emscripten#27207).EPOLL_CLOEXECandepoll_create,epoll_create1,epoll_ctl,epoll_waitandepoll_pwaitfor Emscripten (theepoll_eventtype andEPOLL*constants were already defined for the target)test_emscripten, version-gated so that all currently released Emscripten versions (including the 3.1.68 CI pin) are unaffected__EMSCRIPTEN_major__macros are non-integer aliases of new uppercase forms, and the tiny version component is now tracked so that point releases can be distinguishedTested against Emscripten stable 6.0.7, where the header, type and constant tests run and pass, with the function link tests remaining version-gated until 6.0.8, and against the fully gated skip path.