Skip to content

[Dev-Guide]: Dealing with PR blockers - #712

Merged
kirtchev-adacore merged 2 commits into
rust-lang:mainfrom
kirtchev-adacore:dealing-with-pr-blockers
Aug 14, 2026
Merged

[Dev-Guide]: Dealing with PR blockers#712
kirtchev-adacore merged 2 commits into
rust-lang:mainfrom
kirtchev-adacore:dealing-with-pr-blockers

Conversation

@kirtchev-adacore

@kirtchev-adacore kirtchev-adacore commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@kirtchev-adacore kirtchev-adacore self-assigned this Jul 14, 2026
tshepang
tshepang reviewed Jul 15, 2026
View reviewed changes
Comment thread src/dev-guide.rst

@tshepang tshepang Jul 15, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we should limit discussion to team meets... I think it's fine to just say "bring up the issue to the team"

View changes since the review

@kirtchev-adacore kirtchev-adacore Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Updated.

@kirtchev-adacore
kirtchev-adacore force-pushed the dealing-with-pr-blockers branch from c697784 to d90582d Compare July 15, 2026 11:08
tshepang
tshepang approved these changes Jul 15, 2026
View reviewed changes

@tshepang tshepang left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, but maybe better to wait for @PLeVasseur approval also

View changes since this review

@kirtchev-adacore
kirtchev-adacore force-pushed the dealing-with-pr-blockers branch from d90582d to 3335b23 Compare July 24, 2026 12:42
@rustbot

rustbot commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

PLeVasseur
PLeVasseur requested changes Jul 31, 2026
View reviewed changes

@PLeVasseur PLeVasseur left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this up @kirtchev-adacore!

I had some thoughts on where we could tighten things up a bit.

View changes since this review

Comment thread src/dev-guide.rst Outdated
Comment thread src/dev-guide.rst Outdated
PLeVasseur
PLeVasseur approved these changes Aug 14, 2026
View reviewed changes

@PLeVasseur PLeVasseur left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for adding this, @kirtchev-adacore!

View changes since this review

@kirtchev-adacore
kirtchev-adacore added this pull request to the merge queue Aug 14, 2026
Merged via the queue into rust-lang:main with commit 084dc91 Aug 14, 2026
3 checks passed
@kirtchev-adacore
kirtchev-adacore deleted the dealing-with-pr-blockers branch August 14, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tshepang tshepang tshepang approved these changes
@PLeVasseur PLeVasseur PLeVasseur approved these changes

Assignees

@kirtchev-adacore kirtchev-adacore

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kirtchev-adacore @rustbot @tshepang @PLeVasseur