Converge features search bar onto shared filter helpers - #2247
Merged
Conversation
The /features filter bar was the lone search box the #2220 unification missed, so its labels rendered in the old normal style while every sibling index now shows the shared eyebrow style. Route its labels and fields through search_label_class/search_field_class so it matches. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 1 Skim 👀 view-only styling; one partial routed through existing helpers, no logic change
What is the goal of this PR and why is this important?
The
/featuresfilter bar was the lone search box the #2220 filter/search unification missed, so its labels rendered in the old normal style (gray, non-uppercase) while every sibling index page now shows the shared eyebrow style. This converges it so the page matches.How did you approach the change?
Routed the partial's 6 labels through
search_label_classand its 6 inputs (search field, 3 selects, 2 date fields) throughsearch_field_class, dropping the hand-rolled class strings. No behavior change — same params, live submit, and magnifier icon; the fields also pick up the shared border/shadow/focus:ring-blue-200treatment.UI Testing Checklist
/featuresfilter labels render in the uppercase eyebrow style, matching other index pagesAnything else to add?
Left the "Clear filters" button as-is (
btn btn-utility+ its owncollection#clearAndSubmit) — a separate styling axis, not part of the field/label unification.