Stabilize flaky workshops search spec - #2215
Merged
Merged
Conversation
The filter form auto-submits text inputs on a 400ms debounce but checkboxes immediately, so the query fill and the Windows-audience check triggered two overlapping Turbo-frame reloads. When the debounced reload landed mid-assertion the frame was briefly unfiltered, failing ~1 run in 3. Drain the debounced full-text submit (assert the intermediate filtered state) before opening the dropdown so the two reloads can't overlap. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 test-only sequencing fix, no app code changed
Closes #2214
What is the goal of this PR and why is this important?
spec/system/workshops_spec.rb:22fails ~1 run in 3 on the Windows-audience dropdown, unrelated to any branch — it gets blamed on whoever's PR hits it next.How did you approach the change?
queryfill and the checkboxcheckfired two overlapping Turbo-frame reloads; a debounced reload landing mid-assertion left the frame briefly unfiltered.Anything else to add?