Skip directories ending with .rb when collecting analysis targets#454
Merged
sinsoku merged 1 commit intoruby:masterfrom May 10, 2026
Merged
Conversation
mame
approved these changes
May 10, 2026
`Dir.glob("**/*.{rb,rbs}")` matches not only files but also directories
whose names end with `.rb` or `.rbs`. Such directories exist in real
projects (e.g. the `http_parser.rb` gem directory inside rubygems'
VCR cassettes), and `Service#batch` then crashes with `Errno::EISDIR`
while trying to `File.read` them.
Filter the glob result to regular files only.
sinsoku
force-pushed
the
skip-directories-with-rb-suffix
branch
from
2da4fbf to
ba6be58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dir.glob("**/*.{rb,rbs}")matches not only files but also directories whose names end with.rbor.rbs.Such directories exist in real projects (e.g. the
http_parser.rbgem directory inside rubygems' VCR cassettes), andService#batchthen crashes withErrno::EISDIRwhile trying toFile.readthem.Filter the glob result to regular files only.