Clean up QoS test entities (backport #285) - #289
Open
mergify[bot] wants to merge 1 commit into
Open
Conversation
Signed-off-by: Timothy Simpson <simothytimpson@gmail.com> (cherry picked from commit 70218ee)
ahcorde
approved these changes
Aug 26, 2026
Contributor
|
Pulls: #289
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The client and service QoS tests violate the
rmw_destroy_node()precondition (see rmw.h#L184-L188) by leaving entities active, causing failures in RMW implementations that enforce entity cleanup.This PR adds explicit creation verification checks as well as correctly destroying entities after QoS checks are complete.
Is this user-facing behavior change?
Did you use Generative AI?
Additional Information
This is an automatic backport of pull request #285 done by [Mergify](https://mergify.com).