Skip to content

Enable RMW isolation for single process tests (backport #983) - #985

Open
mergify[bot] wants to merge 1 commit into
lyricalfrom
mergify/bp/lyrical/pr-983
Open

Enable RMW isolation for single process tests (backport #983)#985
mergify[bot] wants to merge 1 commit into
lyricalfrom
mergify/bp/lyrical/pr-983

Conversation

@mergify

@mergify mergify Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Description

#960 enabled RMW isolation for test_tf2 launch tests but not single process tests that call rclcpp::init / rclpy.init.

When testing with rmw_zenoh, those still connect to default tcp/localhost:7447 with an infinite peer connect timeout, so session open can hang and ctest reports gtest.missing_result.

That showed up as an intermittent zenoh nightly failure: 119 passed, 120 failed on test_message_filter with no source changes.

This PR wraps remaining ROS-init tests with the fixture:

  • test_tf2 / tf2_ros: ament_add_ros_isolated_gtest for gtests that call rclcpp::init
  • tf2_ros_py: session-scoped conftest.py (ament_python has no CMake isolated runner)

Fixes # (issue)

Is this user-facing behavior change?

No

Did you use Generative AI?

Yes. Cursor (Grok 4.6) for diagnosis and the isolation wiring.

Additional Information

Launch isolation from #960 is unchanged.


This is an automatic backport of pull request #983 done by Mergify.

Signed-off-by: Yadunund Vijay <yadunund@gmail.com>
(cherry picked from commit bcee5a2)

# Conflicts:
#	test_tf2/CMakeLists.txt
#	test_tf2/package.xml
@mergify mergify Bot added the conflicts label Sep 3, 2026
@mergify

mergify Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-pick of bcee5a2 has failed:

On branch mergify/bp/lyrical/pr-983
Your branch is up to date with 'origin/lyrical'.

You are currently cherry-picking commit bcee5a2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   tf2_ros/CMakeLists.txt
	modified:   tf2_ros/package.xml
	new file:   tf2_ros_py/conftest.py
	modified:   tf2_ros_py/package.xml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test_tf2/CMakeLists.txt
	both modified:   test_tf2/package.xml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant