Enable RMW isolation for single process tests (backport #983) - #985
Open
mergify[bot] wants to merge 1 commit into
Open
Enable RMW isolation for single process tests (backport #983)#985mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
Signed-off-by: Yadunund Vijay <yadunund@gmail.com> (cherry picked from commit bcee5a2) # Conflicts: # test_tf2/CMakeLists.txt # test_tf2/package.xml
Contributor
Author
|
Cherry-pick of bcee5a2 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#960 enabled RMW isolation for
test_tf2launch tests but not single process tests that callrclcpp::init/rclpy.init.When testing with
rmw_zenoh, those still connect to defaulttcp/localhost:7447with an infinite peer connect timeout, so session open can hang and ctest reportsgtest.missing_result.That showed up as an intermittent zenoh nightly failure: 119 passed, 120 failed on
test_message_filterwith no source changes.This PR wraps remaining ROS-init tests with the fixture:
test_tf2/tf2_ros:ament_add_ros_isolated_gtestfor gtests that callrclcpp::inittf2_ros_py: session-scopedconftest.py(ament_python has no CMake isolated runner)Fixes # (issue)
Is this user-facing behavior change?
No
Did you use Generative AI?
Yes. Cursor (Grok 4.6) for diagnosis and the isolation wiring.
Additional Information
Launch isolation from #960 is unchanged.
This is an automatic backport of pull request #983 done by Mergify.