Repository navigation
Conversation
…ignment. Move the (so far ununused) VersionedStreamerField in the right header and dictionary. Attach that type as the data type of the test RVersionStreamerField which has been updated to record the class and use its alignment and sizeof. Without this fix, the test asserting inside RNTuple due to the zero value alignment.
Support the case where the class information is passed by name rather than by TClass pointer (eg. the action ReadCollectionDouble32)
In TBufferFile::ReadClass properly set the byte count returned to kOverflowCount when the byte count in the stream was not updated (was too large).
Test Results 21 files 21 suites 3d 14h 6m 1s ⏱️ For more details on these failures, see this check. Results for commit 7b9378f. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is build on top of #23661 (so the first commit can be ignored/skipped).
Add a warning in TMessage when going over the 2GB limit.
Solve a few issues in the new ByteCount mechanism
Improve and extend the error message in case of issue with the bytecounts and bytecounts stack.