Skip to content

[Python] Check std::array type without string matching - #23323

Merged
guitargeek merged 1 commit into
root-project:masterfrom
guitargeek:asnumpy-array-typecheck
Sep 10, 2026
Merged

[Python] Check std::array type without string matching#23323
guitargeek merged 1 commit into
root-project:masterfrom
guitargeek:asnumpy-array-typecheck

Conversation

@guitargeek

Copy link
Copy Markdown
Contributor

This is more general than matching the type name, which depends on how types get represented by cppyy.

@guitargeek
guitargeek requested a review from aaronj0 September 9, 2026 14:51
@guitargeek guitargeek self-assigned this Sep 9, 2026
@guitargeek guitargeek changed the title [df][test] Check std::array type without string matching [Python] Check std::array type without string matching Sep 9, 2026
This is more general than matching the type name, which depends on how
types get represented by cppyy.
@guitargeek
guitargeek force-pushed the asnumpy-array-typecheck branch from b795b20 to 8c81d4f Compare September 9, 2026 14:53

@aaronj0 aaronj0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Test Results

    19 files      19 suites   3d 4h 49m 9s ⏱️
 3 880 tests  3 878 ✅ 0 💤 2 ❌
64 901 runs  64 898 ✅ 1 💤 2 ❌

For more details on these failures, see this check.

Results for commit 8c81d4f.

@guitargeek
guitargeek merged commit 95c3578 into root-project:master Sep 10, 2026
28 of 35 checks passed
@guitargeek
guitargeek deleted the asnumpy-array-typecheck branch September 10, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants