[RF] Only integrate own observables in RooRealSumPdf expected events - #23297
Open
guitargeek wants to merge 1 commit into
Open
[RF] Only integrate own observables in RooRealSumPdf expected events#23297guitargeek wants to merge 1 commit into
guitargeek wants to merge 1 commit into
Conversation
RooRealSumPdf::createExpectedEventsFunc() created the yield integral over the full normalization set that was passed in. Variables in that set that are not dependents of the pdf don't contribute to the expected event count, but they ended up in the integration set anyway. Besides being wasteful, this could create inconsistent integral objects: for example, with a channel index variable in the normalization set (as passed down by RooAddPdf::compileForNormSet() in all-extendable mode when the RooRealSumPdf is the component of a simultaneous mixture), the analytical integration cache of the RooRealSumPdf was corrupted, leading to a crash in analyticalIntegralWN(). Restrict the integration set to the observables that the pdf actually depends on. 🤖 Done with the help of AI
Test Results 19 files 19 suites 3d 3h 19m 40s ⏱️ Results for commit 5dafed4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RooRealSumPdf::createExpectedEventsFunc() created the yield integral over the full normalization set that was passed in. Variables in that set that are not dependents of the pdf don't contribute to the expected event count, but they ended up in the integration set anyway. Besides being wasteful, this could create inconsistent integral objects: for example, with a channel index variable in the normalization set (as passed down by RooAddPdf::compileForNormSet() in all-extendable mode when the RooRealSumPdf is the component of a simultaneous mixture), the analytical integration cache of the RooRealSumPdf was corrupted, leading to a crash in analyticalIntegralWN().
Restrict the integration set to the observables that the pdf actually depends on.
🤖 Done with the help of AI