Skip to content

[core] deprecate obsolete PosixThreadInc.h #23296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpiparo merged 4 commits into from
Sep 11, 2026
Merged

[core] deprecate obsolete PosixThreadInc.h #23296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23c62be
[core] deprecate PosixThreadInc.h header
ferdymercury Sep 8, 2026
9e155cf
[RN] mention PosixThreadInc obsolete
ferdymercury Sep 8, 2026
897ad83
[core] emit warning when using deprecated PosixThreadInc header
ferdymercury Sep 8, 2026
fd28779
[core] do not generate dict for deprecated header
ferdymercury Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README/ReleaseNotes/v642/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ The `TMVA_SOFIE_GNN` tutorials have been migrated to this workflow and produce i
* The header `Rpair.h` is deprecated and will be removed after ROOT 6.44.
* The headers `Htypes.h` and `Gtypes.h` that were deprecated in ROOT 6.20 will now emit warnings and will be fully removed in ROOT 6.44. Use instead `Rtypes.h`.
* The header `GLConstants.h` is no longer part of ROOT installed headers.
* The header `PosixThreadInc.h` is deprecated and will be removed after ROOT 6.44. Use instead `<ctime>` and `<cstdlib>`.
* The header `RStringView.h` deprecated in ROOT 6.14 will now emit warnings and will be fully removed after ROOT 6.44. Use `ROOT/RStringView.hxx` instead.
* The header `snprintf.h` is deprecated (will emit warnings) and will be removed in ROOT 6.44. Use instead `<cstdio>`.
* The header `Strlen.h` is deprecated and will be removed in ROOT 6.44. Use `<cstring>` directly as a replacement. `NEED_STRING` macro should not be defined or an error will be raised.
Expand Down
1 change: 0 additions & 1 deletion core/thread/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ else()
TPosixMutex.h
TPosixThread.h
TPosixThreadFactory.h
PosixThreadInc.h
)
endif()

Expand Down
1 change: 1 addition & 0 deletions core/thread/inc/PosixThreadInc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#ifndef ROOT_PosixThreadInc
#define ROOT_PosixThreadInc

#warning "This header is deprecated and will be removed after ROOT 6.44, use instead <cstdlib> and <ctime>"

//////////////////////////////////////////////////////////////////////////
// //
Expand Down
2 changes: 1 addition & 1 deletion core/thread/src/TPosixCondition.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@

#include "TPosixCondition.h"
#include "TPosixMutex.h"
#include "PosixThreadInc.h"
Comment thread
ferdymercury marked this conversation as resolved.

#include <ctime>
#include <cerrno>


Expand Down
3 changes: 0 additions & 3 deletions core/thread/src/TPosixMutex.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,7 @@
// //
//////////////////////////////////////////////////////////////////////////

#include "TThread.h"
#include "TPosixMutex.h"
#include "PosixThreadInc.h"


////////////////////////////////////////////////////////////////////////////////
/// Create a posix mutex lock.
Expand Down
Loading