Skip to content

Fix negative value on node collector#1110

Open
0xfornax wants to merge 1 commit into
masterfrom
fix-negatively-signed-value-err
Open

Fix negative value on node collector#1110
0xfornax wants to merge 1 commit into
masterfrom
fix-negatively-signed-value-err

Conversation

@0xfornax
Copy link
Copy Markdown
Member

@0xfornax 0xfornax commented Jun 1, 2026

Checks which validator states should be considered and use skimmable amount to avoid negative values on the rewards estimate.
Closes #1107

…amount to avoid negative values on the rewards estimate
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

Coverage Report

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/rocketpool/node/collectors 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/rocketpool/node/collectors/node-collector.go 0.00% (ø) 3503 (+118) 0 3503 (+118)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Node Collector aborts metric collection on negative megapool reward value (abi: negatively-signed value cannot be packed into uint parameter)

1 participant