Put generated code in target namespace - #329
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 914f07de2e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fc11fa8 to
812e7f1
Compare
812e7f1 to
c79dfd9
Compare
c79dfd9 to
d05ae7f
Compare
1 participant
🤖 sez:
This branch scopes generated pybind11 helpers to their declaration namespaces, placing reusable
trampolines and template binders under target::semiwrap_generated and translation-unit-local helpers
in target-scoped anonymous namespaces while preserving initialization order and behavior. It also
removes generated binding metadata in favor of optional TemplateData.namespace overrides, restores
incremental generation, and adds inline_code_namespace inference/overrides so header-level inline code
executes in the correct target namespace.
This would make #323 largely irrelevant -- which is good because there was a compilation penalty there.