fix(git): resolve index-pack memory access out of bounds when cloning pushed packs#1737
Merged
Conversation
This was referenced Jul 10, 2026
Merged
Member
Author
This was referenced Jul 10, 2026
Merged
…real git-remote-http
…16KiB completes The WASM runner dropped the SOCK_NONBLOCK bit from socket(2) and returned EBADF for fcntl(F_GETFL/F_SETFL) on host-net socket fds, so guest libcurl (git-remote-http, mbedTLS in-guest) ran its TLS socket in blocking mode. Any smart-HTTP upload larger than one TLS record (16384 bytes plaintext) deadlocked: curl checks for an early server response mid-upload, and the blocking recv() waited on a server that was itself waiting for the rest of the POST body. Also allocate host-net fds below FD_SETSIZE (1024) because libcurl's select-based Curl_poll/curl_multi_fdset silently drop fds >= FD_SETSIZE from the pollset, which stalls non-blocking transfers. - wasm-runner.mjs: parse SOCK_NONBLOCK (0x4000) in net_socket, honor O_NONBLOCK via fd_fdstat_get/fd_fdstat_set_flags for host-net sockets, and start host-net fds at 600 instead of 4096. - node_import_cache.rs: bump NODE_IMPORT_CACHE_ASSET_VERSION for the runner asset change.
NathanFlurry
force-pushed
the
stack/fix-git-resolve-index-pack-memory-access-out-of-bounds-when-cloning-pushed-packs-lynmozyn
branch
from
July 16, 2026 07:40
288b968 to
37c9ba6
Compare
NathanFlurry
force-pushed
the
stack/fix-execution-honor-sock_nonblock-on-host-net-sockets-so-git-push-16kib-completes-tvswwyws
branch
from
July 16, 2026 07:40
90ccb60 to
1c712f6
Compare
NathanFlurry
changed the base branch from
stack/fix-execution-honor-sock_nonblock-on-host-net-sockets-so-git-push-16kib-completes-tvswwyws
to
main
July 16, 2026 07:43
NathanFlurry
deleted the
stack/fix-git-resolve-index-pack-memory-access-out-of-bounds-when-cloning-pushed-packs-lynmozyn
branch
July 16, 2026 07:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.