Skip to content

fix: treat null & undefined as no-scope markers#3

Merged
ridvanaltun merged 1 commit into
ridvanaltun:masterfrom
TobiTenno:fix/null-scope-marker-after-commitlint-load
Jul 26, 2026
Merged

fix: treat null & undefined as no-scope markers#3
ridvanaltun merged 1 commit into
ridvanaltun:masterfrom
TobiTenno:fix/null-scope-marker-after-commitlint-load

Conversation

@TobiTenno

Copy link
Copy Markdown
Contributor

Summary

  • @commitlint/load merges config with es-toolkit, which turns array null entries into undefined
  • Configs using [null] for optional/absent scopes then fail with scopes: "undefined"
  • Treat null and undefined as no-scope markers; omit them from error messages

Test plan

  • Existing unit tests pass
  • New test: [undefined] allows missing scope (commitlint load behavior)
  • Against romcal: ci: bump the default group across 1 directory with 10 updates passes

@TobiTenno
TobiTenno force-pushed the fix/null-scope-marker-after-commitlint-load branch from ae59d80 to e1754c0 Compare July 4, 2026 00:31
@TobiTenno

Copy link
Copy Markdown
Contributor Author

@ridvanaltun i think this finishes fixing #2

@TobiTenno

Copy link
Copy Markdown
Contributor Author

@ridvanaltun could you please review and merge this? #2 is still an issue

@ridvanaltun
ridvanaltun merged commit d50c281 into ridvanaltun:master Jul 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants