Notes how each retired conformance hash differs - #252
Merged
Merged
Conversation
The retention record's Note on the lock-upgrade hazard says every chart hash a generated conformance case retires carries a suffix derived from the using module's name. The literal hashes do; the three content-hashed charts are hashes of a source whose comment holds the suffix, so they differ per module without carrying it. Adds a dated foot Note to ADR-0012 naming each hash under the one of the two ways it takes. Zero removed lines under docs/adr/. The branch touches no gated path (lib/, test/, config/, mix.exs, mix.lock), so no gate applies; CI runs it on the request. Refs: sp-ne8c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A dated foot Note on ADR-0012 (retention and retirement) makes one sentence of its 2026-09-29 Note on the lock-upgrade hazard exact. That Note says every chart hash a generated conformance case retires "carries a suffix derived from the using module's name". Every such hash is derived from the module's name, in one of two ways:
@conformance_hash_suffix, for the adapter retirement block, the never-stored miss, the capability case and the tombstone-read case.The Note decides nothing and removes nothing:
git diff origin/main -- docs/adr/shows zero removed lines, and the earlier Note's conclusion (two hosts running the suite in one database never retire the same hash) holds for both kinds.Gate
This branch touches no gated path (the gate's build paths are
lib/,test/,config/,mix.exsandmix.lock), so no local gate applies; CI runs the full quality gate on the request. No changelog fragment:changelog.d/README.mdexcludes ADRs.In-turn review and direction check
Every claim in the Note was checked against
lib/statifier_persistence/testing/storage_conformance.exonmainat9f9eaa0, by anchor:@conformance_hash_suffixis the first sixteen hex characters of the SHA-256 ofinspect(__MODULE__)in the using module;@conformance_retire_hashand the hashes in "adapter: a hash this store never held is a miss, not a retirement", "facade: a retirement either runs or is declined at open" and "adapter: the tombstone read answers what the retired arm of fetch_chart/2 carries" each end with the suffix;@conformance_loan_sourceand@conformance_renewed_sourcecarry it in a comment, the first retired in the facade create case and the second as the facade migration case's to hash, each throughConformanceRetiringSerialization;conformance_own_chart_a/0adds the same comment toStatifierPersistence.Testing.Charts.chart_a/0's source for "facade: the tombstone check refuses a retired chart and lets a live one through". The Note is appended at the end of the file, after the 2026-09-29 Amendment, under the repo's## Note (date, bead id)heading; the earlier Note and the Amendment are untouched, and nothing flips.