Repository navigation
Says what still carries the token at :debug - #180
Merged
Merged
Conversation
statifier_router 0.10.0 keeps the location token out of its own query log, so the hold desk's moduledoc, the controller's moduledoc and the guide no longer give the router's binds as the reason to keep :debug out of production. They name what remains: the position writes, which Ecto prints with the blob cut short, and the query telemetry event, which carries the position writes and the desk post job's insert. Oban runs its own statements with log: false, so the job insert prints no query log line. The guide and the moduledoc also say where the location is stored - the router's location table, the execution's position_blob in the clear, and the desk post job's arguments - and that whoever can read those tables holds the capability. This app configures no Oban pruner and Oban prunes nothing by default, so the job rows stay. The filter_parameters comment says that "token" also redacts any other param whose key contains it, the CSRF token among them. No config value changes. Refs: se-2poc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Docs and comments only; no config value and no code path changes.
StatifierExamples.HoldDeskmoduledoc: a new "The:debuglimit" paragraph.statifier_router0.10.0 runs its own token statements with Ecto'slog: false; the token still reaches a:debugrepo through the position writes (printed with the blob cut short by Ecto's inspect limit) and through Ecto's query telemetry event, which carries the bound parameters of the position writes and of the desk post job's insert. The bearer paragraph now says where the location is stored and that whoever can read those tables holds the capability.StatifierExamplesWeb.BasicHTTPControllermoduledoc: the stale reason (the router's lookup binds the token) is replaced with what 0.10.0 does and a pointer to the hold desk's moduledoc.config/config.exs: the:filter_parameterscomment says the filter matches any param whose key contains "token", so it also redacts the CSRF token.docs/guides/basichttp-front.md: the bearer-capability section names the three places the location is stored (the router's location table, the execution'sposition_blobin the clear, the desk post job's arguments) and gives the current reason for keeping:debugout of production; the job-row sentence says this app configures no Oban pruner and links back to the bearer section.Verified
mix.lock) starts a pruner only when the:prunerkey is given (Oban.Config's service plugins);config/config.exsgives none.log: conf.log,falseby default (Oban.Repo.default_options/1); this app sets no:log. A throwaway test (not committed) inserted a desk post job inside a repo transaction at:debug: the query log printed onlybeginandcommit, and the repo's query telemetry event for theoban_jobsinsert carried the job's arguments.Ecto.Adapters.SQL's privatelog/5emits the query telemetry event before it reads thelogoption.Phoenix.Logger.filter_values/2discards a value whose key contains a listed string.StatifierExamples.Persistencepassesblob_type: :binary;statifier_persistence's statements set nolog: false.statifier_router'sdocs/adr/0002-addressing.md, the Note of 2026-10-02 on the location token and the query log, at v0.10.0.Provenance
The bead's second fold-item expected the job insert's arguments to appear in Ecto's
:debugquery log. They do not (Oban suppresses its own query log lines); they appear in the query telemetry event, and the text says that instead.Review
Tier: gate (docs and moduledocs). Own review round on the branch before opening; no record text is changed.
mix qualitygreen on the committed tree.