Skip to content

Re-locates the Map-era code cites in ADR-0005, 0017 and 0018 - #685

Merged
johnnyt merged 1 commit into
mainfrom
sb-062y-adr-cite-relocation
Sep 30, 2026
Merged

johnnyt merged 1 commit into
mainfrom
sb-062y-adr-cite-relocation

Conversation

@johnnyt

@johnnyt johnnyt commented Sep 30, 2026

Copy link
Copy Markdown
Member

What

The changes to what the Map draws, the short-form comment in core.send and the editor's note lookup moved code lines that three accepted records cite. This adds one dated foot Note to each record, re-locating each drifted cite by its anchor, read at d38dfb9 (the current main), and naming the cites in the same sections that have not moved:

  • ADR-0018: the cites into map/info.ex (def elements, def idle, defp starts, defp notes, defp findings), editor/map_regions.ex (def map_region, def description_region), the Map hook (export const StatifierBlocksMap, its one this.pushEvent), Context's def outline in describe.ex, and defp describable? in editor.ex. The Note on selection's cites of hover/2 at 9a324a2 describe code that is gone and are left as written, as the new Note says.
  • ADR-0017: the flip Note's cites, and the matching body cites, into core/send.ex (def sentence, @short_form, def delay_words), block_type.ex, palette.ex and describe.ex.
  • ADR-0005: the cites from the decision 7 Amendment of 2026-09-28 on: the decision 7 and decision 1 flip rows (the Map hook, map_regions.ex, assets_test.exs, map_layout_test.exs, README.md sections), the note-command Amendment and its flip rows (handle_event("note-change", ...) now at editor.ex:1850, inspector.ex, edit.ex, note_field_test.exs), the shell Amendment and its flip rows (map_regions.ex, describable?, map_regions_test.exs), and the two Notes on the Map hook below them. Cites above that Amendment are not re-read, as the Note says.

The ADR-0005 Note also records, without reading it against clause 7f, that draw() now sets a this.warnedNoCanvas flag, which the Note of 2026-09-29 on what the hook keeps does not list.

git diff origin/main -- docs/adr/ shows zero removed lines; each Note is appended at the end of its file. mix adr.cites is green (every record citation resolves and is unmoved; the advisories are unchanged and none is on the new lines), so there is no baseline refresh to commit.

No changelog fragment: changelog.d/README.md excludes docs and ADRs.

Gate

Full mix quality green on the exact staged tree committed (3,954 of 3,954 tests, 95.3% coverage, dialyzer, credo, docs and ADR cites clean).

In-turn review

Direction check of the record text: each re-located line was read at d38dfb9 by grepping the named anchor in the named file, and each "placed at" line was read from the record itself, with the older reading checked at its stated commit where a line had been placed twice (describe.ex's def outline at ff04855, 362a0e9 and 9adc029; the hook's lines at 2469e01; map_regions.ex at 8c4d61b). Every anchor still names the thing the record says. Each Note opens as a dated Note carrying no Status: line, decides nothing, amends no clause and edits no line above it; the flip Notes are corrected only by the further Note, never rewritten. The diff is additions only, in docs/adr/ only.

Out of scope and left as found: ADR-0016's flip-Note cites into describe.ex include several that have moved by one line since 520c6d8; they are not cites into the Map files, and that record is not changed here.

The changes to what the Map draws, the short-form comment in core.send
and the editor's note lookup moved code lines that three accepted
records cite. One dated foot Note per record re-locates each drifted
cite by its anchor, read at d38dfb9, and names the cites that have not
moved: ADR-0018's cites into map/info.ex, editor/map_regions.ex, the
Map hook, describe.ex and editor.ex; ADR-0017's flip-Note cites into
core/send.ex, block_type.ex, palette.ex and describe.ex; ADR-0005's
cites from the decision 7 Amendment on, into the Map hook,
map_regions.ex, editor.ex, inspector.ex, edit.ex and their tests. No
line is removed and no record decides anything new.

Record Notes only; no changelog fragment (changelog.d/README.md
excludes ADRs).

Gate: full mix quality green on this exact staged tree (3,954 of 3,954
tests, 95.3% coverage, dialyzer and credo clean, ADR cites green).

Refs: sb-062y
@johnnyt
johnnyt merged commit 9874ead into main Sep 30, 2026
2 checks passed
@johnnyt
johnnyt deleted the sb-062y-adr-cite-relocation branch September 30, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant