Says MapTest's graphs regenerate from the Map - #683
Merged
Merged
Conversation
MapTest's moduledoc said the two teaching documents' graphs are what the reference host's map answered before it moved into the package. The library loan's graph has since been regenerated from the package's own StatifierBlocks.Map when a timed wait gained the clock mark, so it differs from the host's by that one mark. The moduledoc now says the graphs began as the host's answer, are regenerated from the package's Map when what it answers changes, and names the one difference, as MapFixtures' moduledoc already does. Test prose only; no changelog fragment (changelog.d/README.md excludes tests). Gate: full mix quality green on this exact staged tree (3,954 of 3,954 tests, 95.3% coverage, dialyzer and credo clean). Refs: sb-pgsm
johnnyt
force-pushed
the
sb-pgsm-maptest-moduledoc
branch
from
September 30, 2026 11:27
bfe3e4e to
114c51c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
StatifierBlocks.MapTest's moduledoc said the graph for the two teaching documents is what the reference host's map answered before it moved into the package. That no longer holds for the library loan: its graph fixture was regenerated from the package's ownStatifierBlocks.Mapwhen a timed wait gained the clock mark, and differs from the reference host's by that one mark.The moduledoc now says the teaching documents' graphs are the ones checked in under
test/fixtures/map/, that they began as the reference host's answer and are regenerated from the package'sStatifierBlocks.Mapwhen what it answers changes, and names the one difference (the clock mark on the library loan's loan period), pointing atStatifierBlocks.MapFixtures.Test prose only: no
lib/change, no assertion change, no changelog fragment (changelog.d/README.mdexcludes tests).Gate
Full
mix qualitygreen on the exact tree committed (3,954 of 3,954 tests, 95.3% coverage, dialyzer and credo clean, ADR cites unmoved).Review
In-turn review: re-read the diff against the bead's acceptance ("The moduledoc says the graphs are regenerated from StatifierBlocks.Map and names the difference"). Checked each claim against main by anchor at 8346ba7:
StatifierBlocks.MapFixtures' moduledoc ("the library loan's graph was regenerated when a timed wait gained the clock mark, and differs from the reference host's by that one mark on its loan period");MapFixtures.host_graph!/1readstest/fixtures/map/{key}.graph.json, which the test "each teaching document's graph is the reference host's" holds equal tograph(key); the history oftest/fixtures/map/shows the library loan's graph gaining the one"mark": "clock"line on itsWait 21dnode and the patron registration's graph unchanged since it was added. The new text claims only what the test asserts and what the fixtures' history shows. No record text changed. Left as is: the describe block's name and the test's name still say "the reference host's graph"; the comment above that test already names the clock-mark difference, and renaming a test is outside this bead's acceptance.