Skip to content

The stacking test reads the whole rule that hides the region under a hover #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnnyt merged 1 commit into from
Sep 30, 2026
Merged

The stacking test reads the whole rule that hides the region under a hover #680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions test/statifier_blocks/editor/map_regions_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,19 +398,32 @@ if Code.ensure_loaded?(Phoenix.LiveView) do

# The stylesheet draws the layer in the region's place: one grid cell,
# the region transparent while the layer is shown, and the layer with
# no display of its own, so `hidden` keeps it out.
# no display of its own, so `hidden` keeps it out. The region's rule
# under a shown layer is read whole: transparent and nothing else, so
# the region stays in the accessibility tree.
# Sabotage: dropped the rule that makes the region transparent under a
# shown layer; this went red.
# Sabotage: added `visibility: hidden` to that rule; this went red.
# Sabotage: added a second rule selecting the region under a shown
# layer with `display: none`; this went red.
test "the stylesheet stacks the shown layer over the region" do
css = File.read!(Path.expand("../../../assets/css/statifier_blocks.css", __DIR__))
rules = Regex.scan(~r/([^{}]+)\{([^}]*)\}/, css, capture: :all_but_first)

assert css =~
~r/\.sb-map__description-hover:not\(\[hidden\]\)\s*\+\s*\.sb-map__description\s*\{\s*opacity:\s*0;/
region_rules =
for [selectors, body] <- rules,
selector <- String.split(selectors, ","),
selector = String.trim(selector),
selector =~ ~r/\.sb-map__description-hover:not\(\[hidden\]\)/,
String.ends_with?(selector, ".sb-map__description"),
do: body |> String.split() |> Enum.join(" ")

assert region_rules == ["opacity: 0;"]

assert css =~ ~r/\.sb-map__description-frame\s*\{\s*display:\s*grid;/

layer_rules =
for [_all, selectors, body] <- Regex.scan(~r/([^{}]+)\{([^}]*)\}/, css),
for [selectors, body] <- rules,
selector <- String.split(selectors, ","),
String.ends_with?(String.trim(selector), ".sb-map__description-hover"),
do: body
Expand Down
Loading