Notes what 075c7a3 did for ADR-0016 item 8's fallbacks - #679
Merged
Merged
Conversation
johnnyt
force-pushed
the
sb-0o4l-adr-0016-fallback-credit
branch
from
September 30, 2026 11:05
ff5dac4 to
8a87c44
Compare
The flip Note of 2026-09-29 credits item 8's "its delay" and "its event" fallbacks to 075c7a3. That commit pinned them with a test and added one comment to timer_edges/2; the fallback code came with the timer edge in 40cb469 (2026-09-27) and predates the Amendment of 2026-09-29. A dated foot Note says so; the flip Note is not edited, and no line is removed. Gate: full mix quality green on this staged tree (3,951 of 3,951 tests, 95.3% coverage, dialyzer clean, ADR cites green). Refs: sb-0o4l
johnnyt
force-pushed
the
sb-0o4l-adr-0016-fallback-credit
branch
from
September 30, 2026 11:23
8a87c44 to
f3e1134
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ADR-0016's Note of 2026-09-29 ("the Amendment of 2026-09-29 is flipped to accepted") credits item 8's
its delayandits eventfallbacks to075c7a3. That commit did not build them: it pinned them with a render test and added one comment todefp timer_edges/2. The fallbacks in the:timerclause ofdefp edge_line/2came with the timer edge itself in40cb469(2026-09-27) and are already present ata2e008c, the commit the Amendment of 2026-09-29 read its cites at.This PR appends one dated foot Note to
docs/adr/0016-document-describes-itself.mdthat says so. The flip Note is not edited; the Note carries no Status line and decides nothing.git diff origin/main -- docs/adr/shows 25 added lines and zero removed. No changelog fragment:changelog.d/README.mdexcludes docs and ADRs.Refs: sb-0o4l
Gate
Full
mix qualitygreen on the committed tree (3,951 of 3,951 tests, 95.3% coverage, dialyzer clean, ADR cites green: every record citation resolves and is unmoved).Review (in-turn, direction check of the record text)
Every claim in the Note was checked against the repo at
142a391(main when this branch was last rebased).git show 075c7a3 -- lib/changesdescribe.exby one added line, a comment above theis_binary(parent)guard indefp timer_edges/2(describe.ex:534at142a391), and no line ofdefp edge_line/2;4fdf7f8has since reworded that comment, and the Note says so rather than restating its old wording. The testa hand-built timer edge with no readable delay or event reads its delay and its eventis atdescribe_test.exs:1010.git log -S'its delay' -- lib/statifier_blocks/describe.exnames40cb469(2026-09-27, "Adds the describe's timer edge") as the commit that introduced the fallback string, whose message ties it to ADR-0016's Amendment of 2026-09-27;git show a2e008c:lib/statifier_blocks/describe.exalready carries both fallbacks, anda2e008cis an ancestor of075c7a3. The fallback lines are atdescribe.ex:638and:639at142a391, anchored on the:timerclause ofdefp edge_line/2. The flip Note's own reading of item 8 at520c6d8still holds and is left as written. Cites are anchor-qualified and SHA-labelled perdocs/adr/README.md; the Note is appended at the end of the file, so no line another record cites moves. Nothing rejected.Provenance
The branch was rebased onto main after
4fdf7f8(a comment-only change todescribe.ex) landed, and the Note's code cites were re-located by anchor and re-labelled at142a391before merge; the full gate re-ran green on the rebased tree.